Skip site navigation (1)Skip section navigation (2) 
Date:      Fri, 14 Apr 2017 01:56:15 +0000 (UTC)
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r316804 - head/sys/netpfil/pf
Message-ID:  <201704140156.v3E1uFNi057114@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: glebius
Date: Fri Apr 14 01:56:15 2017
New Revision: 316804
URL: https://svnweb.freebsd.org/changeset/base/316804

Log:
  Fix potential NULL deref.
  
  Found by:	PVS Studio

Modified:
  head/sys/netpfil/pf/pf_ioctl.c

Modified: head/sys/netpfil/pf/pf_ioctl.c
==============================================================================
--- head/sys/netpfil/pf/pf_ioctl.c	Fri Apr 14 00:45:09 2017	(r316803)
+++ head/sys/netpfil/pf/pf_ioctl.c	Fri Apr 14 01:56:15 2017	(r316804)
@@ -2428,11 +2428,12 @@ DIOCGETSTATES_full:
 
 #undef ERROUT
 DIOCCHANGEADDR_error:
-		if (newpa->kif)
-			pfi_kif_unref(newpa->kif);
-		PF_RULES_WUNLOCK();
-		if (newpa != NULL)
+		if (newpa != NULL) {
+			if (newpa->kif)
+				pfi_kif_unref(newpa->kif);
 			free(newpa, M_PFRULE);
+		}
+		PF_RULES_WUNLOCK();
 		if (kif != NULL)
 			free(kif, PFI_MTYPE);
 		break;

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201704140156.v3E1uFNi057114>