Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 7 Feb 2016 03:48:40 +0000 (UTC)
From:      "Pedro F. Giffuni" <pfg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r295362 - head/sys/fs/cd9660
Message-ID:  <201602070348.u173meT4000314@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: pfg
Date: Sun Feb  7 03:48:40 2016
New Revision: 295362
URL: https://svnweb.freebsd.org/changeset/base/295362

Log:
  cd9660: Drop an unnecessary check for NULL.
  
  This was unnecessary and also confused Coverity.
  
  Confirmed on:	NetBSD
  CID:		978558

Modified:
  head/sys/fs/cd9660/cd9660_vfsops.c

Modified: head/sys/fs/cd9660/cd9660_vfsops.c
==============================================================================
--- head/sys/fs/cd9660/cd9660_vfsops.c	Sun Feb  7 01:45:24 2016	(r295361)
+++ head/sys/fs/cd9660/cd9660_vfsops.c	Sun Feb  7 03:48:40 2016	(r295362)
@@ -741,8 +741,7 @@ cd9660_vget_internal(mp, ino, flags, vpp
 		if (off + isonum_711(isodir->length) >
 		    imp->logical_block_size) {
 			vput(vp);
-			if (bp != 0)
-				brelse(bp);
+			brelse(bp);
 			printf("fhtovp: directory crosses block boundary %d[off=%d/len=%d]\n",
 			       off +isonum_711(isodir->length), off,
 			       isonum_711(isodir->length));



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201602070348.u173meT4000314>