Date: Fri, 23 Oct 2020 14:46:54 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Hans Petter Selasky <hps@selasky.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r366936 - head/sys/net Message-ID: <20201023114654.GY2643@kib.kiev.ua> In-Reply-To: <966178e3-078f-66d3-8baa-6672b998422e@selasky.org> References: <202010221222.09MCM8qo048407@repo.freebsd.org> <20201022164804.GQ2643@kib.kiev.ua> <69bfca24-40a9-552a-62b3-8ab7b46ff3c7@selasky.org> <e60d3e01-f15a-e8dc-0060-e1df71a519dc@selasky.org> <20201023094621.GW2643@kib.kiev.ua> <966178e3-078f-66d3-8baa-6672b998422e@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Oct 23, 2020 at 01:26:04PM +0200, Hans Petter Selasky wrote:
> On 2020-10-23 11:46, Konstantin Belousov wrote:
> > On Fri, Oct 23, 2020 at 10:04:12AM +0200, Hans Petter Selasky wrote:
> > > On 2020-10-22 19:54, Hans Petter Selasky wrote:
> > > > On 2020-10-22 18:48, Konstantin Belousov wrote:
> > > > > sys/systm.h already includes sys/param.h. Also, sys/param.h already
> > > > > includes
> > > > > sys/types.h.
> > > >
> > > > I'll have a look tomorrow at this. Thanks for pointing out.
> > >
> > > It appears sys/systm.h needs sys/types.h included first:
> > Normally you do
> > #include <sys/param.h>
> > #include <sys/systm.h>
> > and I do not see why it would not work in this case.
> >
> > >
> > > > In file included from /usr/img/freebsd.svn/src/sys/sys/systm.h:44:
> > > > ./machine/atomic.h:230:1: error: unknown type name 'u_char'; did you mean 'char'?
> > > > ATOMIC_CMPSET(char);
> > >
> > > --HPS
>
> Hi,
>
> The following works, but it doesn't make much difference.
It makes a difference because this is an idiomatic an intended use of
the headers.
>
> Do we have a script or tool, which can do this?
I am not aware of.
>
> --HPS
>
> > Index: sys/net/if_infiniband.c
> > ===================================================================
> > --- sys/net/if_infiniband.c (revision 366936)
> > +++ sys/net/if_infiniband.c (working copy)
> > @@ -30,9 +30,8 @@
> > __FBSDID("$FreeBSD$");
> > #include <sys/param.h>
> > +#include <sys/systm.h>
> > #include <sys/kernel.h>
> > -#include <sys/types.h>
> > -#include <sys/systm.h>
> > #include <sys/eventhandler.h>
> > #include <sys/socket.h>
> > #include <sys/sysctl.h>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20201023114654.GY2643>