Date: Mon, 17 Sep 2007 16:40:06 GMT From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@deepcore.dk> To: freebsd-geom@FreeBSD.org Subject: Re: kern/115572: [gbde] gbde partitions fail at 28bit/48bit LBA addressing boundary Message-ID: <200709171640.l8HGe6ol073009@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/115572; it has been noted by GNATS.
From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@deepcore.dk>
To: Pete <xd888cc7541309c3f@f4n.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: kern/115572: [gbde] gbde partitions fail at 28bit/48bit LBA addressing
boundary
Date: Mon, 17 Sep 2007 18:32:45 +0200
Pete wrote:
> Does anyone know if S=F8ren Schmidt's patch (repeated below) is safe to=
> use, and if it is, when it will be commited?
>
> I'm also experiencing this problem, but I haven't dared to try the
> patch yet.
>
> =20
It is safe to use, it fixes a real bug :)
Its just me being way too busy that has held it back from asking commit=20
approval..
-S=F8ren
> The patch:
>
> --- ata-all.c 23 Feb 2007 16:25:08 -0000 1.279
> +++ ata-all.c 19 Aug 2007 09:25:58 -0000
> @@ -738,7 +738,7 @@
>
> =20
>> atadev-flags &=3D ~ATA_D_48BIT_ACTIVE;
>> =20
>
> - if ((request->u.ata.lba >=3D ATA_MAX_28BIT_LBA ||
> + if (((request->u.ata.lba + request->u.ata.count) >=3D ATA_MAX_28BIT_L=
BA ||
> =20
>> request-> u.ata.count256) &&
>> atadev-param.support.command2 & ATA_SUPPORT_ADDRESS48) {
>> =20
>
> .
>
> =20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200709171640.l8HGe6ol073009>