Date: Mon, 13 Dec 2004 21:19:51 +0200 From: Ruslan Ermilov <ru@freebsd.org> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c Message-ID: <20041213191951.GA54360@ip.net.ua> In-Reply-To: <37124.1102943186@critter.freebsd.dk> References: <20041213113310.GB51149@ip.net.ua> <37124.1102943186@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
--9jxsPFA5p3P2qPhR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, Dec 13, 2004 at 02:06:26PM +0100, Poul-Henning Kamp wrote:
> In message <20041213113310.GB51149@ip.net.ua>, Ruslan Ermilov writes:
>=20
> >Another issue:
> >
> >- boot without a diskette in the drive
> >- insert a diskette #1 into the drive
> >- newfs_msdos it
> >- mount_msdosfs it
> >- copy some files onto it
> >- unmount it
> >- insert another (possibly unformatted) diskette #2
> >- mount_msdosfs it and find it somehow succeeds
> >- list the contents of the diskette and find that it's identical
> > to the contents of diskette #1, including MD5 checksums of
> > all files
> >
> >This smells like a bufcache issue, but I may be wrong about it.
>=20
> Sounds like the same thing.
>=20
> Can you try this:
>=20
> =3D=3D=3D=3D //depot/user/phk/phk_bufwork/sys/fs/msdosfs/msdosfs_vfsops.c=
#45 - /bang/p4/phk/phk_bufwork/sys/fs/msdosfs/msdosfs_vfsops.c =3D=3D=3D=3D
> @@ -719,6 +719,7 @@
> error_exit:
> if (bp)
> brelse(bp);
> + vinvalbuf(devvp, V_SAVE, NOCRED, td, 0, 0);
> if (cp !=3D NULL) {
> DROP_GIANT();
> g_topology_lock();
>=20
Doesn't help. Boot with an MS-DOS formatted floppy, mount
and unmount it, then:
Script started on Mon Dec 13 21:15:42 2004
hammer# dd if=3D/dev/fd0 |hd
00000000 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |..............=
=2E.|
*
2880+0 records in
2880+0 records out
1474560 bytes transferred in 47.905143 secs (30781 bytes/sec)
00168000
hammer# mount_msdosfs /dev/fd0 /mnt
hammer# ll /mnt
total 0
-rwxr-xr-x 1 root wheel 0 Dec 13 21:02 foo
hammer# umount /mnt
Script done on Mon Dec 13 21:17:08 2004
Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer
--9jxsPFA5p3P2qPhR
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)
iD8DBQFBvetXqRfpzJluFF4RAouhAJ9JDEm+6DiDF8a0ctsSQ4vQfOMtFgCbB82q
rvkb0IB6OUVpyrGQLHKW+PM=
=M+fr
-----END PGP SIGNATURE-----
--9jxsPFA5p3P2qPhR--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041213191951.GA54360>