Date: Sun, 14 Jun 2015 07:38:08 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: araujo@FreeBSD.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, "src-committers@freebsd.org" <src-committers@freebsd.org>, Allan Jude <allanjude@freebsd.org> Subject: Re: svn commit: r284336 - head/sys/dev/acpi_support Message-ID: <20150614043808.GL2080@kib.kiev.ua> In-Reply-To: <17D20218-2A87-4F1E-BF8C-563C38305C51@gmail.com> References: <201506130555.t5D5tQij003839@svn.freebsd.org> <20150613073746.GJ2080@kib.kiev.ua> <CAGHfRMBuRA2w6y8rG%2BOBEK8qW1e8BSbXyrULvBpgMc=_1fnXKg@mail.gmail.com> <CAOfEmZhjMhje7CwjAKDLgD-QUV5ksV17RNaKpW24uHcsDa3Hdg@mail.gmail.com> <17D20218-2A87-4F1E-BF8C-563C38305C51@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jun 13, 2015 at 03:31:16PM -0700, Garrett Cooper wrote: > On Jun 13, 2015, at 4:30, Marcelo Araujo <araujobsdport@gmail.com> wrote: > > > +1. > > Fixed (r284357/r284358). Thanks! I doubt that anything is fixed. >From a little information I can gather from the r284336 commit message, there was some NULL pointer dereference (may be not, FWIW). The r284336 papered over it, just ignoring the chunk of code when bith env variables are _not_ NULL. Now, the condition is reversed, and since r284336 hide the bug, it is arguable that both env vars were not NULL on the problematic machines. The consequence is that the check is a nop now, since machines do have valid SMBIOS info, and a bug, whatever it is, is not fixed, and probably not even diagnosed.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150614043808.GL2080>