Date: Thu, 11 Sep 2014 11:51:35 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r270850 - in head/sys: i386/i386 i386/include i386/isa x86/acpica Message-ID: <20140911085135.GL2737@kib.kiev.ua> In-Reply-To: <21371080.holR7l8cnU@ralph.baldwin.cx> References: <201408301748.s7UHmc6H059701@svn.freebsd.org> <1432043.pIBGVXe1sj@ralph.baldwin.cx> <20140909085813.GC2737@kib.kiev.ua> <21371080.holR7l8cnU@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
--dGBDEx8Ycw1mGAPo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 10, 2014 at 10:41:00AM -0400, John Baldwin wrote: > On Tuesday, September 09, 2014 11:58:13 AM Konstantin Belousov wrote: > > On Sat, Sep 06, 2014 at 04:04:49PM -0400, John Baldwin wrote: > > Move of the code to initialize CPU from identcpu() to initializecpu() > > seems to be a fix on its own. Since you are moving the fragments > > around, would you mind start using CPUID_MODEL/STEPPING etc constants ? > > The code was ancient, probably predating the defines. >=20 > I will probably split this up into a couple of commits one of which will = be > to move register setting from identcpu.c to initcpu.c. I can look at usi= ng > the constants, but in particular when using CPUID_TO_*() the logic is sli= ghtly > different (e.g. you have to check for model and family values for '6' ins= tead > of '60' or '600'), so I would prefer to do those changes as a separate co= mmit > to help with debugging in the future if I get one wrong. >=20 I only asked about CPUID_MODEL etc constants (masks), which does not require the logic change. I think that CPUID_TO_*() is simply not suitable there. --dGBDEx8Ycw1mGAPo Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUEWKWAAoJEJDCuSvBvK1B0bgP/2zTMXf4074qUDPWqBGkMNZv eNk9SinBlqyanGEE7J38eBZakMkjTV5/VB9+FZsY36Z62pl3hDxQ9k/QOZEX23pJ vh4ZkPORjBfIDL78HY+22EZmBEwNkX9ukvmT/DB/ndPAnB5UN5FzfOnjfbqZtIHY f568XgQAkVo6oo9VbUJqZ2trVuPZTUsIynYPh11nfdmwoRkPiYj+YcrvqFE7PaUq 93uXRCrb8w5/jrujx61jGDTXEnMX39CVlQ0gnjB7W1BP6dTrNagpidLCicEtvyXd 6sh2tF5Y1QgklIqihdHNbkM16LJeQ2d+kkTJY8jksn25jKdwgvCpMdnY962fm/3E LfaTKTZg4QXjR1m20KEg0cvOHVUSB8m8Ea66Ca0B+PfOkoZwGOoLY+S1loS3kD99 9BO8MvYts0F8IhKUfmPAaq+d+kDbCQIGb+1LcneDpOv/v247NSOnYAOIOh64AcTc Ic8iEubGIaBfKJc2BPytNoGq6e/rE1uk6lgMmltDypToLiNyijEIJPKD+tH+o2Yp kNGqx5BVGrHiaAuUdxAy2enbnMKdc2xB/dp/33dD0cAtxeaUVbucQ0aT48cRDnmZ GdkPiq+tctcJtBJOl7kFMYyLNemRZH0fiJjxIyqCO+SUiWVsiB4HqadByIm6uUQ2 hPNdoI+q2MbO/ZgrmmzB =AObg -----END PGP SIGNATURE----- --dGBDEx8Ycw1mGAPo--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140911085135.GL2737>