Date: Sun, 21 Jan 2001 12:23:45 -0800 From: Doug Barton <DougB@FreeBSD.org> To: Sergey Babkin <babkin@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Dramatic cron changes are premature Was: Re: cvs commit: src/usr.sbin/cron/cron cron.8 cron.c cron.h Message-ID: <3A6B4551.7341CAD8@FreeBSD.org> References: <200101202128.f0KLSHR38414@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This needs to be backed out immediately. This isn't even close to what was discussed in -hackers. After LONG, often pointless discussion, the following points were agreed to there. Gerhard Sittig wrote: > I take notice of your (and Greg Black's) reservation / being > opposed, respect it and conclude that the change will have to > - default to the current behaviour (something quite usual for > expanding changes) > - be well documented (something absolutely clear to all of us, > strictly speaking it's way out of imagination for us how > somebody could contribute undocumented stuff ... :) > - yet be enabled easily for those interested in the change to > work for them and free up some of their resources for more > important tasks > - maybe provide knobs (besides the on-off-switch) to customize > behaviour in a more fine grained way I made the additional point that the options should be command line options, instead of environment variables as someone else suggested. Your commit accomplishes none of that. In fact, the proponents of this change were seriously considering creating a new cron with their suggested changes and offering it as a port. It could also easily be argued that this change should be discussed on -arch before going into the tree. In any case, the current situation is entirely unacceptable, and I ask that you revert your change asap. Thanks, Doug Sergey Babkin wrote: > > babkin 2001/01/20 13:28:17 PST > > Modified files: > usr.sbin/cron/cron cron.8 cron.c cron.h > Log: > Added sensible handling of switch to and from daylight saving time > for the jobs that fall into the disappearing or duplicated time > interval. > > PR: bin/24494 > > Revision Changes Path > 1.10 +28 -1 src/usr.sbin/cron/cron/cron.8 > 1.10 +129 -6 src/usr.sbin/cron/cron/cron.c > 1.12 +4 -1 src/usr.sbin/cron/cron/cron.h > > PR: http://www.FreeBSD.org/cgi/query-pr.cgi?pr=24494 > > http://www.FreeBSD.org/cgi/cvsweb.cgi/src/usr.sbin/cron/cron/cron.8.diff?&r1=1.9&r2=1.10&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/src/usr.sbin/cron/cron/cron.c.diff?&r1=1.9&r2=1.10&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/src/usr.sbin/cron/cron/cron.h.diff?&r1=1.11&r2=1.12&f=h -- "Pain heals. Chicks dig scars. Glory . . . lasts forever." -- Keanu Reeves as Shane Falco in "The Replacements" Do YOU Yahoo!? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3A6B4551.7341CAD8>