Date: Wed, 10 Nov 2010 20:29:59 +0100 From: Gary Jennejohn <gljennjohn@googlemail.com> To: Marcel Moolenaar <xcllnt@mac.com> Cc: svn-src-head@freebsd.org, "Andrey V. Elsukov" <ae@FreeBSD.org>, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r215088 - head/sys/geom/part Message-ID: <20101110202959.44759eae@ernst.jennejohn.org> In-Reply-To: <48E80281-F1B2-46A7-90F8-426D9D5CBBD5@mac.com> References: <201011101438.oAAEcqDQ022127@svn.freebsd.org> <48E80281-F1B2-46A7-90F8-426D9D5CBBD5@mac.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 10 Nov 2010 09:40:03 -0800 Marcel Moolenaar <xcllnt@mac.com> wrote: > > On Nov 10, 2010, at 6:38 AM, Andrey V. Elsukov wrote: > > > Author: ae > > Date: Wed Nov 10 14:38:51 2010 > > New Revision: 215088 > > URL: http://svn.freebsd.org/changeset/base/215088 > > > > Log: > > In r212554 name of G_PART_PARM_GEOM and G_PART_PARM_PROVIDER > > ctlreq parameters was changed to "arg0". Fix the last place where > > it is used. > > A regression for sure. Nothing worse than having a good > and clear interface messed up by a lousy implementation > of geom(8)... > > *sigh* > I wondered about this change myself. Juat because it's called arg0 in the declaration doesn't mean that the callers have to use it. Maybe ther was a good reason for it which I don't understand. Consistency, I suppose. -- Gary Jennejohn
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101110202959.44759eae>