Date: Fri, 01 Aug 2008 13:13:15 +0300 From: Giorgos Keramidas <keramida@ceid.upatras.gr> To: Doug Barton <dougb@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf newvers.sh Message-ID: <877ib1kpqc.fsf@kobe.laptop> In-Reply-To: <87ej59kqmr.fsf@kobe.laptop> (Giorgos Keramidas's message of "Fri, 01 Aug 2008 12:53:48 %2B0300") References: <200807161029.m6GATt4V031164@repoman.freebsd.org> <87ej59kqmr.fsf@kobe.laptop>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 01 Aug 2008 12:53:48 +0300, Giorgos Keramidas <keramida@freebsd.org> wrote:
> On Wed, 16 Jul 2008 10:29:42 +0000 (UTC), Doug Barton <dougb@freebsd.org> wrote:
>> dougb 2008-07-16 10:29:42 UTC
>>
>> FreeBSD src repository
>>
>> Modified files: (Branch: RELENG_6)
>> sys/conf newvers.sh
>> Log:
>> SVN rev 180557 on 2008-07-16 10:29:42Z by dougb
>>
>> MFC r179637, r179655, and r180503, the inclusion of the svnversion info
>> for uname.
>>
>> Revision Changes Path
>> 1.69.2.17 +18 -2 src/sys/conf/newvers.sh
>
> Hi Doug,
>
> Instead of trying to guess ${SRCDIR} we could let make tell us its
> value, at the last possible moment, by a patch like the one below.
> Does it look like something we should commit?
>
> %%%
> diff -r fe80b79b9f0e sys/conf/kern.post.mk
> --- a/sys/conf/kern.post.mk Fri Aug 01 02:48:36 2008 +0000
> +++ b/sys/conf/kern.post.mk Fri Aug 01 12:50:18 2008 +0300
> @@ -244,7 +244,7 @@
> ${NORMAL_LINT}
>
> vers.c: $S/conf/newvers.sh $S/sys/param.h ${SYSTEM_DEP}
> - MAKE=${MAKE} sh $S/conf/newvers.sh ${KERN_IDENT}
> + MAKE=${MAKE} SRCDIR=$s sh $S/conf/newvers.sh ${KERN_IDENT}
``SRCDIR=$S'' of course... Sorry for botching the copy/paste here.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?877ib1kpqc.fsf>