Date: Mon, 13 Jan 2014 01:20:35 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Chris Rees <crees@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r339550 - in head/Mk: . Uses Message-ID: <20140113002034.GM97375@ithaqua.etoilebsd.net> In-Reply-To: <201401122116.s0CLG6Wn016253@svn.freebsd.org> References: <201401122116.s0CLG6Wn016253@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--q8dntDJTu318bll0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 12, 2014 at 09:16:06PM +0000, Chris Rees wrote: > Author: crees > Date: Sun Jan 12 21:16:06 2014 > New Revision: 339550 > URL: http://svnweb.freebsd.org/changeset/ports/339550 >=20 > Log: > Strip postgresql code out of bsd.database.mk, and introduce USES=3Dpgsq= l. > =20 > New syntax: > =20 > # Depend on postgresql-client > USES=3D pgsql > =20 > # Depend on postgresql-client at least 9.2 > USES=3D pgsql:9.2+ > =20 > #Depend on postgresql-server at least 9.0 > USES=3D pgsql:9.0+ > WANT_PGSQL=3D server > =20 > Postgresql now supports DEFAULT_VERSIONS, and please note that the > version syntax now includes dots(!); i.e. before it was 90, now 9.0 > =20 > Reviewed by: ade, silence from pgsql@ >=20 It is broken in multiple parts first WANT_PGSQL is checked even when not de= fined resulting multiple lines like: /usr/ports/Mk/Uses/pgsql.mk" line 128: Malformed conditional (${WANT_PGSQL:= M${:Ucontrib}}) if a port only defines USES=3Dpgsql If the first is fixed then the version is not properly defined resulting in= a dependency like: /usr/ports/databases/postgresql-client which doesn't exists. For this kind of change a portmgr review would have been nice and an exp-run even better. regards, Bapt --q8dntDJTu318bll0 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlLTMVIACgkQ8kTtMUmk6EwA9wCeOdxBGweh6asHyQ3Xv2ZTvpqC zKcAniK1A0qOjyxq7KpvHSSSe0aWvHIP =RBGb -----END PGP SIGNATURE----- --q8dntDJTu318bll0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140113002034.GM97375>