Date: Fri, 2 Oct 2009 00:36:06 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Coleman Kane <cokane@freebsd.org> Subject: Re: svn commit: r197654 - head/sys/dev/if_ndis Message-ID: <20091002002534.D21507@delplex.bde.org> In-Reply-To: <86eipno12p.fsf@ds4.des.no> References: <200910010243.n912hpSM034846@svn.freebsd.org> <86eipno12p.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 1 Oct 2009, [utf-8] Dag-Erling Smørgrav wrote: > Coleman Kane <cokane@FreeBSD.org> writes: >> - if (sc->ndis_80211 && vap) >> + if ((sc->ndis_80211 != NULL) && (vap != NULL)) > > sc->ndis_80211 is an int. NULL is a pointer. Also, the number of style bugs was doubled on (almost?) every changed line by adding 2 sets of unnecessary parentheses. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091002002534.D21507>