Date: Fri, 7 Jun 2024 05:33:04 +0800 From: Po-Chuan Hsieh <sunpoet@freebsd.org> To: Charlie Li <vishwin@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, python@freebsd.org Subject: Re: git: b9a3602bb3da - main - devel/py-pyproject_hooks: Update to 1.1.0 Message-ID: <CAMHz58R800TNCWn4NqfopYtROoGf7nQxMkvzks6ERik5_vznXA@mail.gmail.com> In-Reply-To: <34165e76-5b3d-4ed6-8395-c679ecb1e110@freebsd.org> References: <202405191726.44JHQM14064613@gitrepo.freebsd.org> <34165e76-5b3d-4ed6-8395-c679ecb1e110@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000d26268061a3f6f08 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jun 4, 2024 at 2:08=E2=80=AFAM Charlie Li <vishwin@freebsd.org> wro= te: > Po-Chuan Hsieh wrote: > > The branch main has been updated by sunpoet: > > > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3Db9a3602bb3da661da313a970d4177= a95a1233afc > > > > commit b9a3602bb3da661da313a970d4177a95a1233afc > > Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > > AuthorDate: 2024-05-19 16:17:56 +0000 > > Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> > > CommitDate: 2024-05-19 17:15:43 +0000 > > > > devel/py-pyproject_hooks: Update to 1.1.0 > > > > Changes: > https://github.com/pypa/pyproject-hooks/blob/main/docs/changelog.rst > > > https://pyproject-hooks.readthedocs.io/en/latest/changelog.html > This is causing all setuptools builds under PEP-517 even upstream to fail= : > https://github.com/pypa/pyproject-hooks/issues/192 > https://github.com/pypa/setuptools/issues/4333 > > So far the only fallout here is with devel/py-setuptools58 since it uses > PEP-517 to build, but may want to consider rolling back pyproject_hooks > for now in case it takes a bit for upstream to figure out. > > -- > Charlie Li > ...nope, still don't have an exit line. > > IMHO, we do n=C3=B3t need to do anything right now as py-setuptools58 is no= t used by anything. It means we do not need to revert py-pyproject_hooks. Furthermore, I don't think current PY_SETUPTOOLS and devel/py-setuptools58 are needed in our ports tree. Since we could build almost every python port with pep517 (with minor fixes for the case in its name), we should always use devel/py-setuptools with correct version requirement rather than PY_SETUPTOOLS. In my case, there are 1,310 ports with USE_PYTHON=3Dpep517 and only 3 ports with USE_PYTHON=3Ddistutils which are intentional for simplicity. We should encourage people to convert their ports to pep517 build. And we should preserve PY_SETUPTOOLS for conditional dependency on py-setuptools for Python 3.12+. Best regards, sunpoet --000000000000d26268061a3f6f08 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr">On Tue, Jun 4, 2024 at 2:08=E2=80=AFAM Ch= arlie Li <<a href=3D"mailto:vishwin@freebsd.org" target=3D"_blank">vishw= in@freebsd.org</a>> wrote:<br></div><div class=3D"gmail_quote"><blockquo= te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px = solid rgb(204,204,204);padding-left:1ex">Po-Chuan Hsieh wrote:<br> > The branch main has been updated by sunpoet:<br> > <br> > URL: <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3Db9a3602bb3= da661da313a970d4177a95a1233afc" rel=3D"noreferrer" target=3D"_blank">https:= //cgit.FreeBSD.org/ports/commit/?id=3Db9a3602bb3da661da313a970d4177a95a1233= afc</a><br> > <br> > commit b9a3602bb3da661da313a970d4177a95a1233afc<br> > Author:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org><= br> > AuthorDate: 2024-05-19 16:17:56 +0000<br> > Commit:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org><= br> > CommitDate: 2024-05-19 17:15:43 +0000<br> > <br> >=C2=A0 =C2=A0 =C2=A0 devel/py-pyproject_hooks: Update to 1.1.0<br> >=C2=A0 =C2=A0 =C2=A0 <br> >=C2=A0 =C2=A0 =C2=A0 Changes:=C2=A0 =C2=A0 =C2=A0 =C2=A0 <a href=3D"htt= ps://github.com/pypa/pyproject-hooks/blob/main/docs/changelog.rst" rel=3D"n= oreferrer" target=3D"_blank">https://github.com/pypa/pyproject-hooks/blob/m= ain/docs/changelog.rst</a><br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 <a href=3D"https://pyproject-hooks.readthedocs.io/en/latest/changelo= g.html" rel=3D"noreferrer" target=3D"_blank">https://pyproject-hooks.readth= edocs.io/en/latest/changelog.html</a><br> This is causing all setuptools builds under PEP-517 even upstream to fail:<= br> <a href=3D"https://github.com/pypa/pyproject-hooks/issues/192" rel=3D"noref= errer" target=3D"_blank">https://github.com/pypa/pyproject-hooks/issues/192= </a><br> <a href=3D"https://github.com/pypa/setuptools/issues/4333" rel=3D"noreferre= r" target=3D"_blank">https://github.com/pypa/setuptools/issues/4333</a><br>; <br> So far the only fallout here is with devel/py-setuptools58 since it uses <b= r> PEP-517 to build, but may want to consider rolling back pyproject_hooks <br= > for now in case it takes a bit for upstream to figure out.<br> <br> -- <br> Charlie Li<br> ...nope, still don't have an exit line.<br> <br></blockquote><div><br></div><div>IMHO, we do n=C3=B3t need to do anythi= ng right now as py-setuptools58 is not used by=C2=A0anything.</div><div>It = means we do not need to revert py-pyproject_hooks.</div><div><br></div><div= >Furthermore, I don't think current PY_SETUPTOOLS and devel/py-setuptoo= ls58 are needed in our ports tree.</div><div>Since we could build almost ev= ery python port with=C2=A0pep517 (with minor fixes for the case in its name= ), we should always use devel/py-setuptools with=C2=A0correct=C2=A0version = requirement rather=C2=A0than PY_SETUPTOOLS.</div><div>In my case, there are= 1,310 ports with USE_PYTHON=3Dpep517 and only 3 ports with USE_PYTHON=3Ddi= stutils which are intentional for simplicity.</div><div><br></div><div>We s= hould encourage people to convert their ports to pep517 build.</div><div>An= d we should preserve PY_SETUPTOOLS for conditional dependency=C2=A0on py-se= tuptools for Python 3.12+.</div><div><br></div><div>Best regards,</div><div= >sunpoet</div></div></div> --000000000000d26268061a3f6f08--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58R800TNCWn4NqfopYtROoGf7nQxMkvzks6ERik5_vznXA>