Date: Wed, 27 Mar 2002 04:01:09 +0900 From: "Akinori MUSHA" <knu@iDaemons.org> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.port.mk Message-ID: <86d6xrgnm2.wl@archon.local.idaemons.org> In-Reply-To: <200203250848.g2P8mlf77991@freefall.freebsd.org> References: <200203250848.g2P8mlf77991@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
At Mon, 25 Mar 2002 00:48:47 -0800 (PST),
sobomax wrote:
> sobomax 2002/03/25 00:48:47 PST
>
> Modified files:
> Mk bsd.port.mk
> Log:
> - Significantly reduce overhead associated with bsd.port.mk by replacing .USE
> macro, which was invoking separate make(1) process for each of the main
> targets, with explicit make(1) targets and specifying the dependencies on
> those targets in normal Makefile way. This gives up to 4x speedup. For the
> ports relying on the old functionality (i.e. each main target in a separate
> make(1) process) provide a USE_SUBMAKE knob, which provides old behaviour;
>
> - speed-up dependency registration process by the factor of two, which
> could be a great win especially for things like GNOME and KDE with very long
> dependency chains;
>
> - clean-up internal structure of the file, so that it is easier to understand
> and extend it when necessary.
While the performance increase is really great, I found a problem
which violates POLA where you can no longer make multiple targets in
one invocation of make(1). For example, `make clean build' does not
work as expected, and something like `make reinstall package clean'
seems to fail sometimes, although I don't know if it depends on the
port's dependencies or on the state of the ports' working directories
(cookie files).
So, unless this is a trivial bug you just missed which can be fixed
shortly, I think you'd better back the change out for the moment
pending investigation and solution because 5.0-DP1 is coming soon and
we don't have enough time to make sure we get all the ports and
scripts happy.
Regards,
--
/
/__ __ Akinori.org / MUSHA.org
/ ) ) ) ) / FreeBSD.org / Ruby-lang.org
Akinori MUSHA aka / (_ / ( (__( @ iDaemons.org / and.or.jp
"Somewhere out of a memory.. of lighted streets on quiet nights.."
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86d6xrgnm2.wl>