Date: Wed, 13 May 2026 12:39:36 +0000 From: Olivier Certner <olce@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: beca41dfb55f - main - acpi_spmc(4): Remove XXX from a comment about retrieving constraints Message-ID: <6a047108.195e9.25848f99@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=beca41dfb55f0b83612fe8a2aec508944c4b2138 commit beca41dfb55f0b83612fe8a2aec508944c4b2138 Author: Olivier Certner <olce@FreeBSD.org> AuthorDate: 2026-05-04 11:56:52 +0000 Commit: Olivier Certner <olce@FreeBSD.org> CommitDate: 2026-05-13 12:38:18 +0000 acpi_spmc(4): Remove XXX from a comment about retrieving constraints There is really nothing we can do about a DSM function that works on first call but fails on subsequent calls, except calling it only once, which we already do. While here, soften the comment message, as failure was observed with some specific machines only. No functional change. Reviewed by: emaste, obiwac Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D56799 --- sys/dev/acpica/acpi_spmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/acpica/acpi_spmc.c b/sys/dev/acpica/acpi_spmc.c index d8fa5617c8bf..36a2c20e6be8 100644 --- a/sys/dev/acpica/acpi_spmc.c +++ b/sys/dev/acpica/acpi_spmc.c @@ -451,7 +451,7 @@ acpi_spmc_get_constraints(device_t dev) dsm_index.regular = DSM_GET_DEVICE_CONSTRAINTS; } - /* XXX It seems like this DSM fails if called more than once. */ + /* It seems like this DSM can fail if called more than once. */ status = acpi_EvaluateDSMTyped(sc->handle, (uint8_t *)&dsm_set->uuid, dsm_set->revision, dsm_index.i, NULL, &result, ACPI_TYPE_PACKAGE);home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a047108.195e9.25848f99>