Date: Sat, 10 Oct 2009 22:14:28 +0200 From: Harald Schmalzbauer <h.schmalzbauer@omnilan.de> To: Kostik Belousov <kostikbel@gmail.com> Cc: freebsd-current@freebsd.org Subject: Re: shutdown not working with uart console Message-ID: <4AD0EB24.5020700@omnilan.de> In-Reply-To: <20091010175115.GC2259@deviant.kiev.zoral.com.ua> References: <4AD0BAFB.6020207@omnilan.de> <20091010175115.GC2259@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4A06FE475FD7C249E7596AC5 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: quoted-printable Kostik Belousov schrieb am 10.10.2009 19:51 (localtime): =2E.. > I wondering whether I was too conservative in r195509. > Please try this. >=20 > diff --git a/sys/kern/kern_exit.c b/sys/kern/kern_exit.c > index 39b48e0..b96cdbf 100644 > --- a/sys/kern/kern_exit.c > +++ b/sys/kern/kern_exit.c > @@ -340,10 +340,10 @@ exit1(struct thread *td, int rv) > =20 > if (ttyvp !=3D NULL) { > sx_xunlock(&proctree_lock); > - vn_lock(ttyvp, LK_EXCLUSIVE | LK_RETRY); > - if (ttyvp->v_type !=3D VBAD) > + if (vn_lock(ttyvp, LK_EXCLUSIVE) =3D=3D 0) { > VOP_REVOKE(ttyvp, REVOKEALL); > - VOP_UNLOCK(ttyvp, 0); > + VOP_UNLOCK(ttyvp, 0); > + } > sx_xlock(&proctree_lock); > } > } Great, thanks a lot, this fixes my problem :) There's one LOR left at shutdown (vfs_mount+ffs_vfsops) and one at=20 startup (unionfs+ufs) but that's completele unrelated I guess. Thanks, -Harry --------------enig4A06FE475FD7C249E7596AC5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.13 (FreeBSD) iEYEARECAAYFAkrQ6ysACgkQLDqVQ9VXb8izfACfYoLVRR5VuZXhIK2bKfYfpSeh /toAn3BDNDKOEgu0D1PV5c5+RhwmgWHp =07/d -----END PGP SIGNATURE----- --------------enig4A06FE475FD7C249E7596AC5--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4AD0EB24.5020700>