Date: Tue, 03 Jun 2003 22:56:00 -0700 From: Terry Lambert <tlambert2@mindspring.com> To: Scott Long <scottl@freebsd.org> Cc: Jeff Roberson <jroberson@chesapeake.net> Subject: Re: umtx/libthr SMP fixes. Message-ID: <3EDD89F0.C3FED9CE@mindspring.com> References: <20030602230746.U69975-100000@mail.chesapeake.net> <3EDCCB27.5020707@freebsd.org><3EDD04CF.80101@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Scott Long wrote: > Bryan Liesner wrote: > It's very hard to imagine Jeff's patches causing a problem at the point > that the PR mentions. Have you confirmed the problem in a kernel that > was build in a totally clean environment? The changed code is not protecting a traversal of a proc struct member with a proc lock in two places. What's hard to imagine? Even if it's weren't necessary to protect that FOREACH loop (it's necessary; but even if it weren't...), locking the proc could easily serialize a number of operations through that or other code which could save it from interference. -- Terry
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3EDD89F0.C3FED9CE>