Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 Mar 2009 06:21:52 +0000 (UTC)
From:      Marcel Moolenaar <marcel@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r189611 - head/sys/dev/pci
Message-ID:  <200903100621.n2A6LqdZ049000@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: marcel
Date: Tue Mar 10 06:21:52 2009
New Revision: 189611
URL: http://svn.freebsd.org/changeset/base/189611

Log:
  Fix a buglet in revision 189401: when restoring a 64-bit BAR,
  write the upper 32-bits in the adjacent bar. The consequences
  of the buglet were severe enough though: a machine check.

Modified:
  head/sys/dev/pci/pci.c

Modified: head/sys/dev/pci/pci.c
==============================================================================
--- head/sys/dev/pci/pci.c	Tue Mar 10 02:12:03 2009	(r189610)
+++ head/sys/dev/pci/pci.c	Tue Mar 10 06:21:52 2009	(r189611)
@@ -3464,7 +3464,7 @@ pci_alloc_map(device_t dev, device_t chi
 	 */
 	pci_write_config(child, *rid, map, 4);
 	if (maprange == 64)
-		pci_write_config(child, *rid + 4, map, 4);
+		pci_write_config(child, *rid + 4, map >> 32, 4);
 	pci_write_config(child, PCIR_COMMAND, cmd, 2);
 
 	/* Ignore a BAR with a base of 0. */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200903100621.n2A6LqdZ049000>