Date: Tue, 14 Sep 2021 14:06:48 +0200 From: Emmanuel Vadot <manu@bidouilliste.com> To: Jan Beich <jbeich@FreeBSD.org> Cc: Emmanuel Vadot <manu@FreeBSD.org>, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 4f3befc2a362 - main - ports-mgmt/pkg-devel: Add an option for building with sanitizer Message-ID: <20210914140648.73654736944b31545473f311@bidouilliste.com> In-Reply-To: <bl4v-ml3d-wny@FreeBSD.org> References: <202109141010.18EAA5Yb091282__26781.7482979567$1631614221$gmane$org@gitrepo.freebsd.org> <bl4v-ml3d-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 14 Sep 2021 13:51:18 +0200
Jan Beich <jbeich@FreeBSD.org> wrote:
> Emmanuel Vadot <manu@FreeBSD.org> writes:
>
> > -OPTIONS_DEFINE= DOCS
> > +OPTIONS_DEFINE= DOCS SAN
> > +SAN_DESC= Enable sanitizers (ASAN and UBSAN)
>
> FWIW, other ports use different option name:
>
> net-p2p/c-lightning/Makefile
> 38:ASAN_CONFIGURE_ENABLE= address-sanitizer
> 39:ASAN_DESC= Compile with address-sanitizer
>
> security/snort3/Makefile
> 35:ADDRESSSANITIZER_DESC= Enable address sanitizer
> 44:ADDRESSSANITIZER_CMAKE_BOOL= ENABLE_ADDRESS_SANITIZER
> 41:THREADSANITIZER_DESC= Enable thread sanitizer
> 54:THREADSANITIZER_CMAKE_BOOL= ENABLE_THREAD_SANITIZER
Yes but this activate all sanitizer supported by pkg (asan and ubsan
for now) not just asan.
> >
> > +.if ${PORT_OPTIONS:MSAN}
> > +CONFIGURE_ARGS+= --with-asan --with-ubsan
> > +.endif
>
> With option helpers it can be more declarative e.g.,
>
> SAN_CONFIGURE_WITH= asan ubsan
Didn't knew that, will fix this later.
--
Emmanuel Vadot <manu@bidouilliste.com> <manu@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210914140648.73654736944b31545473f311>