Date: Wed, 19 Feb 2020 16:57:19 -0600 From: Kyle Evans <kevans@freebsd.org> To: Joerg Sonnenberger <joerg@bec.de> Cc: Jeff Roberson <jeff@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r358133 - head/sys/vm Message-ID: <CACNAnaF%2B9Ux_%2BCjkZuoucx-0od5XCN7AKg4P7QXT0GMeeZKzQw@mail.gmail.com> In-Reply-To: <20200219224900.GA108593@bec.de> References: <202002192234.01JMYNxX084607@repo.freebsd.org> <20200219224900.GA108593@bec.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Feb 19, 2020 at 4:49 PM Joerg Sonnenberger <joerg@bec.de> wrote: > > On Wed, Feb 19, 2020 at 10:34:23PM +0000, Jeff Roberson wrote: > > Author: jeff > > Date: Wed Feb 19 22:34:22 2020 > > New Revision: 358133 > > URL: https://svnweb.freebsd.org/changeset/base/358133 > > > > Log: > > Silence a gcc warning about no return from a function that handles every > > possible enum in a switch statement. I verified that this emits nothing > > as expected on clang. radix relies on constant propagation to eliminate > > any branching from these access routines. > > __builtin_unreachable() ? > We seem to call that __unreachable() to address compilers where it may not be defined, but it does seem to be the ideal way to handle it.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaF%2B9Ux_%2BCjkZuoucx-0od5XCN7AKg4P7QXT0GMeeZKzQw>