Date: Thu, 21 Mar 2002 16:19:38 -0800 (PST) From: Matthew Dillon <dillon@apollo.backplane.com> To: John Baldwin <jhb@FreeBSD.ORG> Cc: smp@FreeBSD.ORG Subject: Re: Giant instrumentation Message-ID: <200203220019.g2M0Jcw03488@apollo.backplane.com> References: <XFMail.20020321172542.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
:Kelly Yancey implemented most of the syscall Giant instrumentation :stuff I outlined in an earlier e-mail. I have since mostly finished :it and changed a few things. Most of the changes were design changes :so that the instrumentation stuff was as separated from the rest of :the kernel (and thus easily condionitionally compiled out with minimal :impact) as possible. Also, it now provides better support for handling :other ABIs. It's not complete yet (it only has instrumentation for :the native ABI at the moment) but I wanted to post this patch for :feedback. I have tested it some and it is being tested some more on :alpha and x86 at the moment. The patch can be found at: : :http://www.FreeBSD.org/~jhb/patches/giantvars.patch : :-- : :John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ This is extreme overkill. Unless you an Kelly plan on doing all the work of instrumenting everything, I don't think many developers are going to want to deal with this. I certainly don't. I think what I have in there now not only works just fine, it's also easily understood and straightforward. This patch is unnecessarily complex and way too far disassociated (hidden) from the code it is supposed wrap to be of any tangible benefit to -current development. I know I'm being harsh here, but that is my opinion. -Matt Matthew Dillon <dillon@backplane.com> To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200203220019.g2M0Jcw03488>