Date: Wed, 09 Dec 2015 11:18:54 +0900 From: Hajimu UMEMOTO <ume@FreeBSD.org> To: Eric van Gyzen <vangyzen@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r291994 - head/include Message-ID: <yge1tawwei9.wl-ume@FreeBSD.org> In-Reply-To: <201512081609.tB8G9mfd053070@repo.freebsd.org> References: <201512081609.tB8G9mfd053070@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, >>>>> On Tue, 8 Dec 2015 16:09:48 +0000 (UTC) >>>>> Eric van Gyzen <vangyzen@FreeBSD.org> said: vangyzen> Author: vangyzen vangyzen> Date: Tue Dec 8 16:09:48 2015 vangyzen> New Revision: 291994 vangyzen> URL: https://svnweb.freebsd.org/changeset/base/291994 vangyzen> Log: vangyzen> resolver: fix the build of some ports, broken by r289315 vangyzen> vangyzen> r289315 required time_t and struct timespec to be defined before vangyzen> including <resolv.h>. This broke the build of net-mgmt/sx, at least. vangyzen> vangyzen> Include <sys/timespec.h> in resolv.h to fix this with minimal pollution. vangyzen> vangyzen> Reported by: Raphael Kubo da Costa <rakuco> vangyzen> MFC after: 3 days vangyzen> Sponsored by: Dell Inc. It seems wrong. We should not have pollution from timespec.h, here. You should consider moving them into __res_state_ext like NetBSD does. Sincerely, -- Hajimu UMEMOTO ume@mahoroba.org ume@FreeBSD.org http://www.mahoroba.org/~ume/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?yge1tawwei9.wl-ume>