Date: Fri, 12 Jun 1998 11:35:23 -0700 From: John Polstra <jdp@polstra.com> To: julian@FreeBSD.ORG Cc: committers@FreeBSD.ORG Subject: Re: cvs commit: src/sys/net if_ethersubr.c if_fddisubr.c if_loop.c if_var.h src/sys/netatalk ddp_output.c src/sys/netinet if_ether.c ip_input.c ip_output.c Message-ID: <199806121835.LAA12854@austin.polstra.com> In-Reply-To: <199806120348.UAA18762@freefall.freebsd.org> References: <199806120348.UAA18762@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In article <199806120348.UAA18762@freefall.freebsd.org>,
Julian Elischer <julian@freebsd.org> wrote:
> julian 1998/06/11 20:48:20 PDT
>
> Modified files:
> sys/net if_ethersubr.c if_fddisubr.c if_loop.c
> if_var.h
> sys/netatalk ddp_output.c
> sys/netinet if_ether.c ip_input.c ip_output.c
> Log:
> Go through the loopback code with a broom..
> Remove lots'o'hacks.
> looutput is now static.
>
> Other callers who want to use loopback to allow shortcutting
> should call the special entrypoint for this, if_simloop(), which is
> specifically designed for this purpose. Using looutput for this purpose
> was problematic, particularly with bpf and trying to keep track
> of whether one should be using the charateristics of the loopback interface
> or the interface (e.g. if_ethersubr.c) that was requesting the loopback.
> There was a whole class of errors due to this mis-use each of which had
> hacks to cover them up.
>
> Consists largly of hack removal :-)
>
> Revision Changes Path
> 1.49 +35 -97 src/sys/net/if_ethersubr.c
> 1.31 +30 -60 src/sys/net/if_fddisubr.c
> 1.33 +62 -27 src/sys/net/if_loop.c
> 1.9 +3 -3 src/sys/net/if_var.h
> 1.10 +9 -0 src/sys/netatalk/ddp_output.c
> 1.47 +10 -10 src/sys/netinet/if_ether.c
> 1.90 +2 -7 src/sys/netinet/ip_input.c
> 1.72 +4 -4 src/sys/netinet/ip_output.c
On a new -current kernel with these changes, I've gotten this console
message 4 times in 2 hours:
if_simloop: can't handle af=0
The machine is just sitting around not doing anything in particular.
--
John Polstra jdp@polstra.com
John D. Polstra & Co., Inc. Seattle, Washington USA
"Self-knowledge is always bad news." -- John Barth
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199806121835.LAA12854>