Date: Wed, 26 Feb 2020 15:12:32 -0800 From: Ravi Pokala <rpokala@freebsd.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org> Subject: Re: svn commit: r358317 - head/sys/kern Message-ID: <FB73859F-402B-4766-9937-363DCEA8E19A@panasas.com> In-Reply-To: <20200226215550.GO5741@FreeBSD.org> References: <202002251911.01PJBLDP091875@repo.freebsd.org> <23A820B4-2E13-4E3E-B734-C7950298C286@panasas.com> <20200226215550.GO5741@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----Original Message-----
From: Gleb Smirnoff <glebius@freebsd.org>
Date: 2020-02-26, Wednesday at 13:55
To: Ravi Pokala <rpokala@freebsd.org>
Cc: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org>
Subject: Re: svn commit: r358317 - head/sys/kern
On Tue, Feb 25, 2020 at 12:02:29PM -0800, Ravi Pokala wrote:
R> When sendfile_swapin() sweeps through pages in search for a bogus page
R> skip first and last pages. This is a micro optimisation.
R>
R> Yes, but *why* skip the first and last pages?
We may have inserted bogus pages in the middle of a request. We never substitute
first or last.
--
Gleb Smirnoff
Oh god, "bogus_page" -- Panasas had to jump through a bunch of hoops involving bogus_page and our RAIDing-across-sectors GEOM class years ago. <shudder>
-Ravi (rpokala@)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?FB73859F-402B-4766-9937-363DCEA8E19A>