Date: Fri, 14 Dec 2012 23:05:12 -0800 From: Rui Paulo <rpaulo@felyko.com> To: Alfred Perlstein <alfred@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin <jhb@freebsd.org> Subject: Re: svn commit: r244105 - in head/sys: kern sys Message-ID: <C2392E5C-932F-44C3-A784-917FABC9D5ED@felyko.com> In-Reply-To: <201212121042.51362.jhb@freebsd.org> References: <201212110123.qBB1NpOV060501@svn.freebsd.org> <201212121042.51362.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12 Dec 2012, at 07:42, John Baldwin <jhb@freebsd.org> wrote: > On Monday, December 10, 2012 8:23:51 pm Alfred Perlstein wrote: >> Author: alfred >> Date: Tue Dec 11 01:23:50 2012 >> New Revision: 244105 >> URL: http://svnweb.freebsd.org/changeset/base/244105 >> >> Log: >> Switch the hardwired WITNESS panics to kassert_panic. >> >> This is an ongoing effort to provide runtime debug information >> useful in the field that does not panic existing installations. >> >> This gives us the flexibility needed when shipping images to a >> potentially large audience with WITNESS enabled without worrying >> about formerly non-fatal LORs hurting a release. >> >> Sponsored by: iXsystems > > Witness doesn't panic on LORs. These are all bigger violations for things > like doing sx_sunlock() on a exclusively locked sx lock. That is not safe and > is merely going to result in data corruption and other unpleasantness. This > sounds like a very bad idea. Did you talk about this anywhere (I have not > caught up on various lists yet, so apologies if this has been discussed.) Eww. This is indeed pretty bad. I would like to see this commit reverted. Regards, -- Rui Paulo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C2392E5C-932F-44C3-A784-917FABC9D5ED>