Date: Sat, 5 Sep 1998 21:58:19 +0100 (BST) From: Doug Rabson <dfr@nlsystems.com> To: Matthew Dillon <dillon@backplane.com> Cc: "Andrey A. Chernov" <ache@nagual.pp.ru>, John Birrell <jb@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/gen sleep.c Message-ID: <Pine.BSF.4.01.9809052157410.796-100000@herring.nlsystems.com> In-Reply-To: <199809051816.LAA22705@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 5 Sep 1998, Matthew Dillon wrote: > The sleep code is totally broken in regards to its comparisons. The > argument is an unsigned int, but values are stored in time_t which is > currently a signed long. The code, as it stands, is not clean if either > time_t changes from signed to unsigned, or if time_t changes from a 32 bit > value to a 64 bit value. Since there is no harm in doing multiple > sleeps, why not just fix the code? We no tv_sec must be at least large > enough to hold INT_MAX, so: Looks fine to me. If Andrey agrees, why don't you commit this. -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 951 1891 Fax: +44 181 381 1039
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.01.9809052157410.796-100000>