Date: Thu, 14 Feb 2019 12:42:28 -0800 (PST) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Mark Johnston <markj@freebsd.org> Cc: Warner Losh <imp@bsdimp.com>, "Rodney W. Grimes" <rgrimes@freebsd.org>, Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344129 - head Message-ID: <201902142042.x1EKgSwf087717@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <20190214191329.GB50900@raichu>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Thu, Feb 14, 2019 at 12:00:22PM -0700, Warner Losh wrote: > > On Thu, Feb 14, 2019 at 11:29 AM Rodney W. Grimes < > > > > Differential Review: https://reviews.freebsd.org/D19193 > > > > > > You sited a differential, but not give any attribution > > > to the external source :-( > > > > > > > The differential review has that information. > > External contributors should be recognized by having their names appear > in the commit logs. We even bother to put a special line in the commit template for this. Further it has been standard operating procedure for at least as long as I have been back that submitters are infact recognized in commit messages. You have, again, summarily dismissed valid feedback. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201902142042.x1EKgSwf087717>