Date: Fri, 17 May 2024 06:48:16 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Vladimir Druzenko <vvd@freebsd.org> Cc: Tobias Kortkamp <tobik@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 5c97fbea8cb6 - main - *: Spell PORTREVISION correctly Message-ID: <Zkb9sO6k_vy6ZxTN@FreeBSD.org> In-Reply-To: <714f05a7-007a-4f16-991e-c53d36f9a083@freebsd.org> References: <202405131305.44DD5p58063913@gitrepo.freebsd.org> <714f05a7-007a-4f16-991e-c53d36f9a083@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 16, 2024 at 10:15:34PM +0300, Vladimir Druzenko wrote: > 13.05.2024 16:05, Tobias Kortkamp пишет: > > commit 5c97fbea8cb6cc44d19d98a9fa77db86410aebed > > > > -PORTEVISION= 1 > > -POPRTREVISION= 1 > > -PORTREvISION= 1 > > -PORTREVISIOMN= 1 > > -PORTERVISION= 1 > > -PORTREVIDSION= 1 > > -PORTREVSION= 1 > > -PORTREVIDSION= 1 > > -PORTREIVSION= 1 > > -PORTREVISIOPN= 1 > > -PORTREVISIOn= 1 > > -PORTEVISION= 1 > > -PORTREVIDSION= 1 > > They look like typos when entered manually. Yup, looks like it, IDK why people seldom or never do "make -V PKGNAME" before commit to rule out potential typos. > Wouldn't it be better to make use PORTREVISION on every port mandatory? > It's also easier to do a mass bump. Nah, that would be disgusting! Forced PORTREVISION lines would add lots of needless cognitive load on the Makefile reader, let alone the repo churn itself. I'm generally against artificial harness against people's stupidity. It might help stupid people, but at the expense of smart and careful ones' comfort. Just don't forget to "make -V PKGNAME" and we all would be fine. :-) ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Zkb9sO6k_vy6ZxTN>