Date: Sun, 15 Aug 1999 09:34:45 +0930 From: Greg Lehey <grog@lemis.com> To: Poul-Henning Kamp <phk@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha diskslice_machdep.c src/sys/cam/scsi scsi_cd.c scsi_da.c src/sys/contrib/dev/fla fla.c src/sys/dev/ata ata-disk.c atapi-fd.c src/sys/dev/ccd ccd.c src/sys/dev/ida ida_disk.c src/sys/dev/vinum vinumdaemon.c vinuminterrupt.c ... Message-ID: <19990815093445.E456@freebie.lemis.com> In-Reply-To: <199908141140.EAA18540@freefall.freebsd.org>; from Poul-Henning Kamp on Sat, Aug 14, 1999 at 04:40:52AM -0700 References: <199908141140.EAA18540@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday, 14 August 1999 at 4:40:52 -0700, Poul-Henning Kamp wrote:
> phk 1999/08/14 04:40:51 PDT
>
> Modified files:
> sys/alpha/alpha diskslice_machdep.c
> sys/cam/scsi scsi_cd.c scsi_da.c
> sys/contrib/dev/fla fla.c
> sys/dev/ata ata-disk.c atapi-fd.c
> sys/dev/ccd ccd.c
> sys/dev/ida ida_disk.c
> sys/dev/vinum vinumdaemon.c vinuminterrupt.c vinumio.c
> vinumrequest.c
> sys/dev/vn vn.c
> sys/i386/isa diskslice_machdep.c wd.c wfd.c
> sys/isa fd.c
> sys/kern kern_physio.c subr_diskslice.c
> subr_dkbad.c vfs_aio.c
> sys/miscfs/specfs spec_vnops.c
> sys/pc98/pc98 atcompat_diskslice.c diskslice_machdep.c
> fd.c wd.c
> sys/sys buf.h conf.h disklabel.h diskslice.h
> dkbad.h
> sys/ufs/ufs ufs_disksubr.c
> Log:
> Spring cleaning around strategy and disklabels/slices:
>
> Introduce BUF_STRATEGY(struct buf *, int flag) macro, and use it throughout.
> please see comment in sys/conf.h about the flag argument.
>
> Remove strategy argument from all the diskslice/label/bad144
> implementations, it should be found from the dev_t.
>
> Remove bogus and unused strategy1 routines.
>
> Remove open/close arguments from dssize(). Pick them up from dev_t.
>
> Remove unused and unfinished setgeom support from diskslice/label/bad144 code.
>
> Revision Changes Path
> 1.12 +2 -2 src/sys/dev/vinum/vinumdaemon.c
--- vinumdaemon.c 1999/08/07 08:06:05 1.11
+++ vinumdaemon.c 1999/08/14 11:40:37 1.12
@@ -34,7 +34,7 @@
* otherwise) arising in any way out of the use of this software, even if
* advised of the possibility of such damage.
*
- * $Id: vinumdaemon.c,v 1.11 1999/08/07 08:06:05 grog Exp $
+ * $Id: vinumdaemon.c,v 1.12 1999/08/14 11:40:37 phk Exp $
*/
#include <dev/vinum/vinumhdr.h>
@@ -183,7 +183,7 @@
void
recover_io(struct request *rq)
{
- vinumstrategy(rq->bp); /* reissue the command */
+ BUF_STRATEGY(rq->bp, 0); /* reissue the command */
}
> 1.38 +2 -2 src/sys/dev/vinum/vinumio.c
--- vinumio.c 1999/08/14 06:26:32 1.37
+++ vinumio.c 1999/08/14 11:40:37 1.38
@@ -33,7 +33,7 @@
* otherwise) arising in any way out of the use of this software, even if
* advised of the possibility of such damage.
*
- * $Id: vinumio.c,v 1.37 1999/08/14 06:26:32 grog Exp $
+ * $Id: vinumio.c,v 1.38 1999/08/14 11:40:37 phk Exp $
*/
#include <dev/vinum/vinumhdr.h>
@@ -836,7 +836,7 @@
*dlp = *lp;
bp->b_flags &= ~B_INVAL;
bp->b_flags |= B_WRITE;
- vinumstrategy(bp); /* write it out */
+ BUF_STRATEGY(bp, 0); /* write it out */
error = biowait(bp);
bp->b_flags |= B_INVAL | B_AGE;
brelse(bp);
These calls are internal to vinum. Why should they go via BUF_STRATEGY?
Greg
--
See complete headers for address, home page and phone numbers
finger grog@lemis.com for PGP public key
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990815093445.E456>