Date: Wed, 18 Dec 2013 16:40:52 -0500 From: John Baldwin <jhb@freebsd.org> To: "Alexander V. Chernikov" <melifaro@freebsd.org> Cc: svn-src-head@freebsd.org, John-Mark Gurney <jmg@funkthat.com>, src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r259562 - head/usr.bin/netstat Message-ID: <201312181640.52147.jhb@freebsd.org> In-Reply-To: <52B2009E.1060905@FreeBSD.org> References: <201312181825.rBIIPR25014515@svn.freebsd.org> <20131218184512.GM99167@funkthat.com> <52B2009E.1060905@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, December 18, 2013 3:07:58 pm Alexander V. Chernikov wrote: > On 18.12.2013 22:45, John-Mark Gurney wrote: > > Alexander V. Chernikov wrote this message on Wed, Dec 18, 2013 at 18:25 +0000: > >> Author: melifaro > >> Date: Wed Dec 18 18:25:27 2013 > >> New Revision: 259562 > >> URL: http://svnweb.freebsd.org/changeset/base/259562 > >> > >> Log: > >> Switch netstat -rn to use standard API for retrieving list of routes > >> instead of peeking inside in-kernel radix via kget. > >> This permits us to change kernel structures without breaking userland. > >> Additionally, this change provide more reliable and faster output. > >> > >> `Refs` and `Use` fields available in IPv4 by default (and via -W > >> for other families) were removed. `Refs` is radix-specific thing > >> which is not informative for users. `Use` field value is handy sometimes, > >> but a) current API does not support it and b) I'm not sure we will > >> support per-rte pcpu counters in near future. > >> > >> Old method of retrieving data is still supported (either by defining > >> NewTree=0 or running netstat with -A). However, Refs/Use fields are > >> hidden. > >> > >> Sponsored by: Yandex LLC > >> MFC after: 4 weeks > >> PR: kern/167204 > > > > How will this impact the use of netstat -rn -M vmcore -N kernel ? Will > > this change make it not usable, or will you still automatically use > Well. It will probably break in (maybe, near) future. Please don't gratuitiously break things that /usr/sbin/crashinfo runs. It's fine if kvm mode is fragile and requires the binary to be in sync with the kernel and is only used for crash dumps, but it is very useful to extract all sorts of info out of a crash dump. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312181640.52147.jhb>