Date: Tue, 09 Dec 2025 16:40:47 +0000 From: Ed Maste <emaste@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: 63b77ab1554e - stable/14 - kgssapi: Remove broken MOD_UNLOAD code Message-ID: <6938510f.95c8.69d7790a@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch stable/14 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=63b77ab1554eb642ad28c35339f08ccfeaab13e5 commit 63b77ab1554eb642ad28c35339f08ccfeaab13e5 Author: Ed Maste <emaste@FreeBSD.org> AuthorDate: 2025-11-27 16:44:08 +0000 Commit: Ed Maste <emaste@FreeBSD.org> CommitDate: 2025-12-09 16:40:33 +0000 kgssapi: Remove broken MOD_UNLOAD code The module panicked at unload with "recursing but non-recursive rw". There is a comment that "Unloading of the kgssapi module is not currently supported" and the MOD_UNLOAD case falls through to returning EOPNOTSUPP anyway. Just #if 0 the code in the unload path, leaving it as a hint in case someone implements unload support later on. PR: 291249 Reviewed by: rmacklem Fixes: ad704a34bc2c ("Use syscall_helper_register(9) rather than syscall_register().") Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D53949 (cherry picked from commit 6901376f59b870ddbb0d922e3455a388333cd460) (cherry picked from commit ab4f4f4efaac85bbf235e60f2ced4876a9e916f2) --- sys/kgssapi/gss_impl.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/kgssapi/gss_impl.c b/sys/kgssapi/gss_impl.c index ae37cb646f1f..f4b09749fdef 100644 --- a/sys/kgssapi/gss_impl.c +++ b/sys/kgssapi/gss_impl.c @@ -78,12 +78,14 @@ kgss_load(void) return (0); } +#if 0 static void kgss_unload(void) { syscall_helper_unregister(gssd_syscalls); } +#endif int sys_gssd_syscall(struct thread *td, struct gssd_syscall_args *uap) @@ -344,8 +346,10 @@ kgssapi_modevent(module_t mod, int type, void *data) error = kgss_load(); break; case MOD_UNLOAD: +#if 0 kgss_unload(); mtx_destroy(&kgss_gssd_lock); +#endif /* * Unloading of the kgssapi module is not currently supported. * If somebody wants this, we would need to keep track of
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6938510f.95c8.69d7790a>