Date: Fri, 13 Jan 2006 17:17:59 +0000 From: Xin LI <delphij@FreeBSD.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: arch@FreeBSD.org, re@FreeBSD.org Subject: Re: review: patch to restore VLAN kernel API in RELENG_6 Message-ID: <20060113171759.GA1255@hub.freebsd.org> In-Reply-To: <20060113170552.GF83922@FreeBSD.org> References: <20060113170552.GF83922@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, Gleb,
On Fri, Jan 13, 2006 at 08:05:52PM +0300, Gleb Smirnoff wrote:
> Index: sys/dev/bge/if_bge.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/dev/bge/if_bge.c,v
> retrieving revision 1.91.2.7
> diff -u -r1.91.2.7 if_bge.c
> --- sys/dev/bge/if_bge.c 13 Jan 2006 11:51:08 -0000 1.91.2.7
> +++ sys/dev/bge/if_bge.c 13 Jan 2006 17:04:31 -0000
> @@ -2862,7 +2862,7 @@
> * attach that information to the packet.
> */
> if (have_tag) {
> - VLAN_INPUT_TAG(ifp, m, vlan_tag);
> + VLAN_INPUT_TAG_NEW(ifp, m, vlan_tag);
What if "VLAN_INPUT_TAG_2" or something with numerical name?
Just my $0.02, though :-)
Cheers,
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060113171759.GA1255>