Date: Thu, 26 Aug 2004 15:37:52 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Roman Kurakin <rik@cronyx.ru> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom/concat g_concat.c src/sys/geom/label g_label.c src/sys/geom/mirror g_mirror.c src/sys/geom/raid3 g_raid3.c src/sys/geom/stripe g_stripe.c Message-ID: <20040826133752.GP30151@darkness.comp.waw.pl> In-Reply-To: <412DE5B1.9090101@cronyx.ru> References: <200408261242.i7QCgl7m012027@repoman.freebsd.org> <58622.1093524972@critter.freebsd.dk> <20040826131030.GO30151@darkness.comp.waw.pl> <412DE5B1.9090101@cronyx.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Thu, Aug 26, 2004 at 05:29:21PM +0400, Roman Kurakin wrote:
+> >Yes, I know that it should be done this way, but I'm not going to fix
+> >atapi-cd.c, scsi_da.c and scsi_cd.c and who knows what else.
+> >Those classes set error to 0 even when provider has not sectorsize
+> >and mediasize defined.
+> >
+> >
+> Does your code print any warning message in that case?
+> That could force authors of 'buggy' code to fix it.
No, this should be KASSERT() inside g_error_provider():
KASSERT(error == 0 && pp->sectorsize > 0 && pp->mediasize > 0, ("Buggy code."));
--
Pawel Jakub Dawidek http://www.FreeBSD.org
pjd@FreeBSD.org http://garage.freebsd.pl
FreeBSD committer Am I Evil? Yes, I Am!
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFBLeewForvXbEpPzQRAgK9AJ9e+O0ZpiP37+m8Znr7Z2QIfZ6YPACfXCnY
nrabl2+yML/or5MDQJtUyE8=
=Xu2F
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040826133752.GP30151>