Date: Sun, 26 Jul 2009 20:42:21 +1000 From: Peter Jeremy <peterjeremy@optushome.com.au> To: FreeBSD-gnats-submit@freebsd.org, freebsd-ports-bugs@freebsd.org Subject: Re: ports/131930: [PATCH] x11-servers/xorg-server coredumps on exit Message-ID: <20090726104221.GA11110@server.vk2pj.dyndns.org> In-Reply-To: <20090518112643.GA48097@server.vk2pj.dyndns.org> References: <200902211153.n1LBrt7F048954@server.vk2pj.dyndns.org> <200902211200.n1LC062l032521@freefall.freebsd.org> <20090518112643.GA48097@server.vk2pj.dyndns.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--GvXjxJ+pjyke8COw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On 2009-May-18 21:26:43 +1000, Peter Jeremy <peter@server.vk2pj.dyndns.org>=
wrote:
>I am no longer able to reproduce the core-dump on a stock
>xorg-server-1.6.1,1 so I believe the problem has been resolved
>upstream (though in a different fashion to my patch).
Looks like I spoke too soon. After my latest upgrade on an 8-current
netbook (i386 with i915), the core-dump-on-exit problem re-appeared
until I re-applied an updated version of the patch (see end). (This
is a regression as it was working OK until my latest port upgrade).
X-related ports list:
damageproto-1.1.0_2
dri-7.4.4,2
dri2proto-2.0
expat-2.0.1
fixesproto-4.0
fontsproto-2.0.2
freetype2-2.3.9_1
gettext-0.17_1
inputproto-1.5.0
kbproto-1.0.3
libGL-7.4.4
libICE-1.0.4_1,1
libSM-1.1.0_1,1
libX11-1.2.1_1,1
libXau-1.0.4
libXaw-1.0.5_1,1
libXdamage-1.1.1
libXdmcp-1.0.2_1
libXext-1.0.5,1
libXfixes-4.0.3_1
libXfont-1.3.4,1
libXi-1.2.1,1
libXinerama-1.0.3,1
libXmu-1.0.4,1
libXp-1.0.0,1
libXpm-3.5.7
libXt-1.0.5_1
libXv-1.0.4,1
libXvMC-1.0.4_1
libXxf86misc-1.0.1
libXxf86vm-1.0.2
libdrm-2.4.11
libfontenc-1.0.4
libiconv-1.13.1
libpciaccess-0.10.6
libpthread-stubs-0.1
libxcb-1.3
libxkbfile-1.0.5
libxkbui-1.0.2_1
pciids-20090224
pixman-0.15.4
pkg-config-0.23_1
printproto-1.0.4
python25-2.5.4_2
videoproto-2.2.2
xcb-proto-1.5
xextproto-7.0.5
xf86miscproto-0.9.2
xf86vidmodeproto-2.2.2
xineramaproto-1.1.2
xkeyboard-config-1.6_1
xorg-server-1.6.1_1,1
xproto-7.0.15
Unfortunately, the original patch no longer applies. A revised patch is:
--- dix/window.c~ 2009-04-15 03:14:56.000000000 +1000
+++ dix/window.c 2009-07-26 20:13:11.257430828 +1000
@@ -963,7 +963,11 @@
}
xfree(dixLookupPrivate(&pWin->devPrivates, FocusPrivatesKey));
dixFreePrivates(pWin->devPrivates);
- xfree(pWin);
+ if (!pParent) {
+ pWin->devPrivates =3D NULL;
+ } else {
+ xfree(pWin);
+ }
return Success;
}
=20
--=20
Peter Jeremy
--GvXjxJ+pjyke8COw
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.12 (FreeBSD)
iEYEARECAAYFAkpsMw0ACgkQ/opHv/APuIf49gCdF9UYuybIZuyx/Pi4waP9sKpE
TKsAoJR540E9HPWylTNCn+mfOrJjYX/6
=wkAW
-----END PGP SIGNATURE-----
--GvXjxJ+pjyke8COw--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090726104221.GA11110>