Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 06 Feb 2024 09:26:57 -0700
From:      Kristof Provost <kp@FreeBSD.org>
To:        Warner Losh <imp@bsdimp.com>
Cc:        Mateusz Guzik <mjguzik@gmail.com>, Gleb Smirnoff <glebius@freebsd.org>, src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Igor Ostapenko <pm@igoro.pro>, Kajetan Staszkiewicz <vegeta@tuxpowered.net>
Subject:   Re: git: 6d4a140acfdf - main - pf: Ensure that st->kif is obtained in a way which respects the r->rpool->mtx mutex
Message-ID:  <0A170E1B-4684-470F-9B4B-65B166191CEE@FreeBSD.org>
In-Reply-To: <CANCZdfqG0%2BzNaTOA9A2%2BnPb3yR7_oxUoPsynZg67=0JPy2SDBA@mail.gmail.com>
References:  <202402052119.415LJKSN037380@gitrepo.freebsd.org> <ZcGTPZLQuDNyhYrm@cell.glebi.us> <B337C14A-EE7C-4209-A416-C1674BCAD903@FreeBSD.org> <CAGudoHG3emJ5SHMYu9%2BivU=QEScpc5QU9zkfN8U47NeL2LAz6A@mail.gmail.com> <CANCZdfqG0%2BzNaTOA9A2%2BnPb3yR7_oxUoPsynZg67=0JPy2SDBA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 5 Feb 2024, at 23:27, Warner Losh wrote:
> On Mon, Feb 5, 2024, 11:24=E2=80=AFPM Mateusz Guzik <mjguzik@gmail.com>=
 wrote:
>
>> On 2/6/24, Kristof Provost <kp@freebsd.org> wrote:
>>> On 5 Feb 2024, at 19:02, Gleb Smirnoff wrote:
>>>> On Mon, Feb 05, 2024 at 09:19:20PM +0000, Kristof Provost wrote:
>>>> K> The branch main has been updated by kp:
>>>> K>
>>>> K> URL:
>>>>
>> https://cgit.FreeBSD.org/src/commit/?id=3D6d4a140acfdf637bb559d371c583=
e4db478e1549
>>>> K>
>>>> K> commit 6d4a140acfdf637bb559d371c583e4db478e1549
>>>> K> Author:     Igor Ostapenko <pm@igoro.pro>
>>>> K> AuthorDate: 2024-02-05 16:22:31 +0000
>>>> K> Commit:     Kristof Provost <kp@FreeBSD.org>
>>>> K> CommitDate: 2024-02-05 21:18:11 +0000
>>>>
>>>> The author should be Kajetan :(
>>>
>>> Indeed it should. My apologies to Kajetan. And Igor as well, although=
 he
>>> probably got the better end of the deal.
>>>
>>
>> You can revert and commit the correct version.
>>
>
> The counts would still count the bad version though...

I=E2=80=99ve done the revert/re-apply dance anyway, so git annotate will =
show the correct author.

> I need to land my -c flag that automates git arc patch more...

If that does what I think it does (i.e. commit the patch locally, rather =
than just staging it) you do indeed need to land that. It=E2=80=99ll be v=
ery helpful.

Best regards,
Kristof



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0A170E1B-4684-470F-9B4B-65B166191CEE>