Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 17 Jun 2022 19:37:32 GMT
From:      Dmitry Chagin <dchagin@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: b6b070eed27e - stable/13 - linux(4): Replace copyin() by fueword32() in handle_futex_death().
Message-ID:  <202206171937.25HJbWFD013488@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by dchagin:

URL: https://cgit.FreeBSD.org/src/commit/?id=b6b070eed27e67562e67db42d825638ad3f5d72a

commit b6b070eed27e67562e67db42d825638ad3f5d72a
Author:     Dmitry Chagin <dchagin@FreeBSD.org>
AuthorDate: 2021-07-29 09:48:59 +0000
Commit:     Dmitry Chagin <dchagin@FreeBSD.org>
CommitDate: 2022-06-17 19:33:19 +0000

    linux(4): Replace copyin() by fueword32() in handle_futex_death().
    
    According to fetch(9) fueword facility designed to fetch atomically
    small amount of data from user space.
    
    Reviewed by:            kib
    Differential Revision:  https://reviews.freebsd.org/D31239
    MFC after:              2 weeks
    
    (cherry picked from commit cb01cc4a1020d7916bcf0f1e774156745c387409)
---
 sys/compat/linux/linux_futex.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/sys/compat/linux/linux_futex.c b/sys/compat/linux/linux_futex.c
index df6c7cdbf74a..9dab78a75af2 100644
--- a/sys/compat/linux/linux_futex.c
+++ b/sys/compat/linux/linux_futex.c
@@ -101,7 +101,6 @@ LIN_SDT_PROBE_DEFINE0(futex, linux_futex, unimplemented_cmp_requeue_pi);
 LIN_SDT_PROBE_DEFINE1(futex, linux_futex, unknown_operation, "int");
 LIN_SDT_PROBE_DEFINE0(futex, linux_set_robust_list, size_error);
 LIN_SDT_PROBE_DEFINE1(futex, linux_get_robust_list, copyout_error, "int");
-LIN_SDT_PROBE_DEFINE1(futex, handle_futex_death, copyin_error, "int");
 LIN_SDT_PROBE_DEFINE1(futex, fetch_robust_entry, copyin_error, "int");
 LIN_SDT_PROBE_DEFINE1(futex, release_futexes, copyin_error, "int");
 
@@ -705,11 +704,9 @@ handle_futex_death(struct linux_emuldata *em, uint32_t *uaddr,
 	int error;
 
 retry:
-	error = copyin(uaddr, &uval, 4);
-	if (error) {
-		LIN_SDT_PROBE1(futex, handle_futex_death, copyin_error, error);
+	error = fueword32(uaddr, &uval);
+	if (error != 0)
 		return (EFAULT);
-	}
 	if ((uval & FUTEX_TID_MASK) == em->em_tid) {
 		mval = (uval & FUTEX_WAITERS) | FUTEX_OWNER_DIED;
 		nval = casuword32(uaddr, uval, mval);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202206171937.25HJbWFD013488>