Date: Wed, 18 Jan 2012 10:11:04 -0500 From: John Baldwin <jhb@freebsd.org> To: Eygene Ryabinkin <rea@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r230007 - in head: etc etc/rc.d share/man/man8 Message-ID: <201201181011.04397.jhb@freebsd.org> In-Reply-To: <76N5o2cbOG1xa%2B/PCENoyerLpsM@HbohoBmewgxm0atwUoKO7zhAAgw> References: <201201120648.q0C6mBio096662@svn.freebsd.org> <g1EPx5ZQC20YwBTAuDerf6U7LFc@gTyb322ruC8B7JPI6PUQyZ3XWfA> <76N5o2cbOG1xa%2B/PCENoyerLpsM@HbohoBmewgxm0atwUoKO7zhAAgw>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, January 18, 2012 6:29:10 am Eygene Ryabinkin wrote:
> Fri, Jan 13, 2012 at 11:21:48AM +0400, Eygene Ryabinkin wrote:
> > But seems like the whole problem is that I used the err() function
> > instead of doing 'echo $errmsg; exit 1'. Such code shouldn't be
> > conditionalized for the devd, since it is only syslog message that
> > worried people; devd doesn't care what is written to the standard
> > output or the standard error by the scripts it invokes once it become
> > the daemon, since everything goes to /dev/null after calling
> > daemon(3).
> >
> > So, seems like that the following dhclient_pre_check() will make
> > everyone happy:
> > {{{
> > dhclient_pre_check()
> > {
> > if [ -z "${rc_force}" ] && ! dhcpif $ifn; then
> > echo "'$ifn' is not a DHCP-enabled interface"
> > exit 1
> > fi
> > }
> > }}}
> > Hadn't tested it yet, but will do it today.
>
> The attached patch that just changes 'err' to 'echo ...; exit 1'
> works fine for me.
>
> Any views on it?
Seems ok to me.
> > The related topic: in the process of grepping for dhclient within
> > /etc, I had found that /etc/netstart still wants to invoke it. But it
> > will do a lone '/etc/rc.d/dhclient quietstart' and this will never
> > be useful in the current state of dhclient: it will refuse to process
> > any commands without the interface being specified. And since we
> > have the invocation of /etc/rc.d/netif just two lines above, I think
> > that it will be good to remove call to dhclient from /etc/netstart.
> >
> > At the time of the original addition of call to dhclient to /etc/netstart
> > (r114213), dhclient script had another form,
> >
http://svnweb.freebsd.org/base/head/etc/rc.d/dhclient?revision=113759&view=markup&pathrev=114213
> > and it was really a normal rc.d script that requires only one argument.
> > Now it is more of a helper-type script.
> > .
> > Am I missing something important here or the removal can really be
> > done?
>
> Anyone can say anything about /etc/netstart issue?
My guess is that it is ok to remove it from netstart.
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201201181011.04397.jhb>