Date: Sun, 11 Nov 2018 18:32:08 -0800 From: Conrad Meyer <cem@freebsd.org> To: "Rodney W. Grimes" <rgrimes@freebsd.org> Cc: woodsb02@freebsd.org, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r340326 - head Message-ID: <CAG6CVpV9tryq0yj9_r-rfinpYwmEwFS32Y25fxq%2BURMvY38BXw@mail.gmail.com> In-Reply-To: <201811110107.wAB17cA2018293@pdx.rh.CN85.dnsmgr.net> References: <CAOc73CCSTx1RMm0B-kBQ7f3TQRe6v=5vr4EgQjAvRUM6KcKTnA@mail.gmail.com> <201811110107.wAB17cA2018293@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
I absolutely approve of Ben's excellent addition to UPDATING, a text document. Your demands for additional scrutiny and time-wasting around code review are ridiculous and disproportionate, and certainly a poor reward for Ben's straightforward and unimpeachable effort to improve our UPDATING documentation. Ben, thank you for submitting and committing the UPDATING change and please try to ignore Rod's hyper-criticism. Conrad On Sat, Nov 10, 2018 at 5:07 PM Rodney W. Grimes <freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > [ Charset UTF-8 unsupported, converting... ] > > On Sun, 11 Nov 2018 at 2:43 am, Rodney W. Grimes < > > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > > > If your going to bother with a differential, and invite people to > > > it you should give them at least 24 hours, and preferably 72 hours > > > to respond to the new review. Reviews that last < 4 hours are not > > > code reviews. > > > > > > -- > > > Rod Grimes > > > rgrimes@freebsd.org > > > > > Hi Rod, > > > > Sorry. The main reason I submitted the code review is because I do not have > > my src commit bit, so needed to seek approval to commit. > > All the more reason for it to wait until the people you *invited* to > the review to have a chance to respond. > > I do not believe an "accept" in a review is an "approve to commit > beyond your normal scope". > > Was cem aware that he was "approving a non src committer to commit > this change to the src tree" as your review has no mention that you > are seeking src bit approval to commit there. > > > > > I felt the need to commit the UPDATING entry was time sensitive, given the > > change it was notifying users of had already been committed. > > > > Regards, > > Ben > > -- > > -- > Rod Grimes rgrimes@freebsd.org >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpV9tryq0yj9_r-rfinpYwmEwFS32Y25fxq%2BURMvY38BXw>