Date: Tue, 17 Jun 2025 12:55:14 +0100 From: Lexi Winter <ivy@freebsd.org> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: Ronald Klop <ronald-lists@klop.ws>, Cy Schubert <cy@freebsd.org>, dev-commits-src-main@freebsd.org, dev-commits-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: git: b6e33f0cd536 - main - rc.d/mountcritlocal: Make sure zpools are imported for legacy ZFS Message-ID: <aFFXogrkD32X6WVr@freefall.freebsd.org> In-Reply-To: <20250616023154.3D2B730C@slippy.cwsent.com> References: <240137891.21754.1749997280448@localhost> <20250616023154.3D2B730C@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Cy Schubert:
> In message <240137891.21754.1749997280448@localhost>, Ronald Klop writes:
[...]
> > > + if [ "$vfstype" = "zfs" -a "$a" != "#" ]; then
> >
> > Does this mean that a comment # must always be folllowed by a whitespace?
> Yes. It's a hack but it's the only way without grep (when /usr may not be
> mounted). In the very worst case rc.d/zpool will be needlessly executed.
could you not check for a comment using the # variable expansion operator?
i.e. if [ "${a#\#}" != "$a" ] then the variable starts with a # character:
$ echo $line1
#Foo bar
$ echo $line2
Foo bar
$ echo $line3
Foo # bar
$ [ "${line1#\#}" = "$line1" ] || echo comment
comment
$ [ "${line2#\#}" = "$line2" ] || echo comment
$ [ "${line3#\#}" = "$line3" ] || echo comment
$
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
iHUEABYKAB0WIQSyjTg96lp3RifySyn1nT63mIK/YAUCaFFXngAKCRD1nT63mIK/
YHSfAP9+GSKp8kTHklHqe1YGaYA7diJK7ZlTOnlco+Oj0Iw1ewD6A7mpT+xhYAHs
HWCcmkrRKa/C3lxhVyqEGMh4+fHHHw8=
=4b11
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aFFXogrkD32X6WVr>