Date: Sat, 27 Feb 2021 13:23:14 +1100 From: Kubilay Kocak <koobs@FreeBSD.org> To: Ed Maste <emaste@freebsd.org>, John Baldwin <jhb@freebsd.org> Cc: freebsd-git <freebsd-git@freebsd.org> Subject: Re: Adopting "Fixes" trailer Message-ID: <5695f4e8-3f05-c7f6-6ddc-7ad3b2a5a091@FreeBSD.org> In-Reply-To: <CAPyFy2DwhqD6rRVLa6nE-EskN3bec=S72PsO5T3BS4_poihLHQ@mail.gmail.com> References: <CAPyFy2BbjPZgkcLLRNNA-y19tpyYBKOT6FN8JNX4=hmDSdScLw@mail.gmail.com> <75c9ad1e-c7ca-8a22-cfe5-6434b3685ccc@FreeBSD.org> <CAPyFy2DwhqD6rRVLa6nE-EskN3bec=S72PsO5T3BS4_poihLHQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 19/02/2021 6:30 am, Ed Maste wrote: > On Thu, 18 Feb 2021 at 11:53, John Baldwin <jhb@freebsd.org> wrote: >> >>> https://reviews.freebsd.org/D28693 >> >> Huh, at first I thought this was to auto-close issues on GitHub. I think >> this is a good idea. If we had a wrapper script for MFC's it could >> auto-squash those as an option perhaps. > > Ah, I think that's typically "Closes: <identifier>" > > Indeed we could search for Fixes in an MFC wrapper; the MFC reminder > mails and https://gitmfc.kernelnomicon.org could also be extended to > list related Fixes commits. Fixes/Closes & References within commit log messages are common keywords to close, and add comments to (respectively) to issues (as properties: or trailers, or within commit bodies (non trailer)) It would be nice to reserve/use those for issue tracker integration/automation. One possible dual-use is "References[:] <commit|issue>" but the value parsing ambiguity between a commit hash and issue number can sometimes cause problems or be less than robust. (that ive seen from other projects) > It is used to identify a commit that is a follow-up bug > fix to a previous commit, and could generally be used instead of "MFC with" > or "X-MFC-with". One nice aspect is that it conveys fix metadata also for > commits that aren't intended for MFC, which may be useful for downstream > projects. Could you clarify this use case, and provide a couple of examples? Sounds like we want a way to link/ref/relate a sequence or particular set/series of commits so they can be identified as logically/functionally related, so as to take a consistent set of actions with them as a group (merge, or anything else) Is that a decent summary?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5695f4e8-3f05-c7f6-6ddc-7ad3b2a5a091>