Date: Sat, 24 Nov 2012 23:24:08 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Konstantin Belousov <kib@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r243142 - in head/sys: fs/nfsclient kern sys Message-ID: <20121124222408.GH1460@garage.freebsd.pl> In-Reply-To: <201211160825.qAG8P6v6047507@svn.freebsd.org> References: <201211160825.qAG8P6v6047507@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Fri, Nov 16, 2012 at 08:25:06AM +0000, Konstantin Belousov wrote: > Author: kib > Date: Fri Nov 16 08:25:06 2012 > New Revision: 243142 > URL: http://svnweb.freebsd.org/changeset/base/243142 > > Log: > In pget(9), if PGET_NOTWEXIT flag is not specified, also search the > zombie list for the pid. This allows several kern.proc sysctls to > report useful information for zombies. > > Hold the allproc_lock around all searches instead of relocking it. > Remove private pfind_locked() from the new nfs client code. > > Requested and reviewed by: pjd > Tested by: pho > MFC after: 3 weeks [...] > @@ -364,12 +374,16 @@ pget(pid_t pid, int flags, struct proc * > struct proc *p; > int error; > > + sx_slock(&allproc_lock); > if (pid <= PID_MAX) > - p = pfind(pid); > + p = pfind_locked(pid); > else if ((flags & PGET_NOTID) == 0) > - p = pfind_tid(pid); > + p = pfind_tid_locked(pid); > else > p = NULL; > + if (p == NULL && (flags & PGET_NOTWEXIT) == 0) > + p = zpfind_locked(pid); > + sx_sunlock(&allproc_lock); > if (p == NULL) > return (ESRCH); I think we should move zpfind_locked() under 'pid <= PID_MAX': sx_slock(&allproc_lock); if (pid <= PID_MAX) { p = pfind_locked(pid); if (p == NULL && (flags & PGET_NOTWEXIT) == 0) p = zpfind_locked(pid); } else if ((flags & PGET_NOTID) == 0) { p = pfind_tid_locked(pid); } else { p = NULL; } sx_sunlock(&allproc_lock); if (p == NULL) return (ESRCH); -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlCxSQgACgkQForvXbEpPzQLJQCg6aP44W5Mwm8LbPnOFsKlBeKE 5vsAn3LchhKKzzO1dPpbv3uydJfVpe6P =pi1E -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121124222408.GH1460>