Date: Thu, 30 Jul 2020 11:31:43 -0700 From: Eric Joyner <erj@freebsd.org> To: Yoshihiro Takahashi <nyan@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r362063 - head/sys/dev/e1000 Message-ID: <CAKdFRZgz7ai62RVgOznaiz%2B0SGt5wt1b6S=YBPFYRBnUrfuD%2BQ@mail.gmail.com> In-Reply-To: <20200725.124911.256350108759170094.nyan@FreeBSD.org> References: <202006111559.05BFxnSa070435@repo.freebsd.org> <20200725.124911.256350108759170094.nyan@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Done in r363711. I apologize for it taking so long. On Fri, Jul 24, 2020 at 8:49 PM Yoshihiro Takahashi <nyan@freebsd.org> wrote: > Please merge this change to stable/12 branch until a proper fix is > done. > > --- > Yoshihiro Takahashi <nyan@FreeBSD.org> > > In article <202006111559.05BFxnSa070435@repo.freebsd.org> > Eric Joyner <erj@FreeBSD.org> writes: > > > Author: erj > > Date: Thu Jun 11 15:59:49 2020 > > New Revision: 362063 > > URL: https://svnweb.freebsd.org/changeset/base/362063 > > > > Log: > > em(4): Always reinit interface when adding/removing VLAN > > > > This partially reverts r361053 since there have been reports > > by users that this breaks some functionality for em(4) > > devices; it seems at first glance that some sort of interface > > restart is required for those cards. > > > > This isn't a proper fix; this unbreaks those users until a proper > > fix is found for their issues. > > > > PR: 240818 > > Reported by: Marek Zarychta <zarychtam@plan-b.pwste.edu.pl> > > MFC after: 3 days > > > > Modified: > > head/sys/dev/e1000/if_em.c > > > > Modified: head/sys/dev/e1000/if_em.c > > > ============================================================================== > > --- head/sys/dev/e1000/if_em.c Thu Jun 11 15:17:13 2020 > (r362062) > > +++ head/sys/dev/e1000/if_em.c Thu Jun 11 15:59:49 2020 > (r362063) > > @@ -4059,7 +4059,6 @@ em_if_needs_restart(if_ctx_t ctx __unused, enum > iflib_ > > { > > switch (event) { > > case IFLIB_RESTART_VLAN_CONFIG: > > - return (false); > > default: > > return (true); > > } >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKdFRZgz7ai62RVgOznaiz%2B0SGt5wt1b6S=YBPFYRBnUrfuD%2BQ>