Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 1 Nov 1996 02:28:43 +1100
From:      Bruce Evans <bde@zeta.org.au>
To:        cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-usrbin@freefall.freebsd.org, phk@freefall.freebsd.org
Subject:   Re: cvs commit:  src/usr.bin/fetch main.c
Message-ID:  <199610311528.CAA03045@godzilla.zeta.org.au>

next in thread | raw e-mail | index | archive | help
>  Modified:    usr.bin/fetch  main.c
>  Log:
>  bin/1933: don't print negative % for huge files (80Mb)

Huge files (size > INT_MAX) are still broken.

Humungous files (size > min(LONG_MAX for ftp, LONG_MAX for ftpd) are
still broken.  ftp reads the restart point using atol(), without
any overflow checking of course...  ftp_file_op() further limits the
restart point to INT_MAX by printing it in %d format.  The format
doesn't match the arg type of course.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199610311528.CAA03045>