Date: Wed, 29 Mar 2017 09:55:04 +0100 From: Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com> To: Ngie Cooper <ngie@FreeBSD.org> Cc: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org> Subject: Re: svn commit: r316106 - head/sys/boot/zfs Message-ID: <20170329085504.iiyfg4mybclkbyti@dhcp-3-128.uk.xensource.com> In-Reply-To: <201703282039.v2SKdONV074149@repo.freebsd.org> References: <201703282039.v2SKdONV074149@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 28, 2017 at 08:39:24PM +0000, Ngie Cooper wrote: > Author: ngie > Date: Tue Mar 28 20:39:24 2017 > New Revision: 316106 > URL: https://svnweb.freebsd.org/changeset/base/316106 > > Log: > Don't shadow read(2) definition with `read` argument in vdev_{create,probe} > > This fixes several -Wshadow warnings introduced in r192194, but now errors > with gcc 6.3.0. > > MFC after: 3 days > Reported by: amd64-gcc-6.3.0 (devel/amd64-xtoolchain-gcc) > Sponsored by: Dell EMC Isilon > > Modified: > head/sys/boot/zfs/zfsimpl.c > > Modified: head/sys/boot/zfs/zfsimpl.c > ============================================================================== > --- head/sys/boot/zfs/zfsimpl.c Tue Mar 28 20:34:02 2017 (r316105) > +++ head/sys/boot/zfs/zfsimpl.c Tue Mar 28 20:39:24 2017 (r316106) > @@ -494,7 +494,7 @@ vdev_find(uint64_t guid) > } > > static vdev_t * > -vdev_create(uint64_t guid, vdev_read_t *read) > +vdev_create(uint64_t guid, vdev_read_t *_read) Just a nit, but IMHO it would be clearer to use read_func, read_helper or some more descriptive name since you where already changing this. Roger.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170329085504.iiyfg4mybclkbyti>