Date: Sat, 04 Mar 2000 11:05:40 +0000 From: Brian Somers <brian@Awfulhak.org> To: Dermot McNally <dermo@mcnally.de> Cc: Dermot McNally <dermot@mcnally.de>, freebsd-net@FreeBSD.ORG, peter@FreeBSD.ORG, jkh@FreeBSD.ORG, joe@FreeBSD.ORG, brian@hak.lan.Awfulhak.org Subject: Re: NAT issues with ppp - a fix Message-ID: <200003041105.LAA07495@hak.lan.Awfulhak.org> In-Reply-To: Message from Brian Somers <brian@Awfulhak.org> of "Sat, 04 Mar 2000 02:18:15 GMT." <200003040218.CAA02929@hak.lan.Awfulhak.org>
next in thread | previous in thread | raw e-mail | index | archive | help
And for those that have noticed there was no patch..... (thanks
Dermot!)
diff -r -N -u --exclude=CVS --exclude=*.o --exclude=*.gz --exclude=*.orig --exclude=*.cat* --exclude=ppp --exclude=*.cat* --exclude=.??* 15/nat_cmd.c 16/nat_cmd.c
--- 15/nat_cmd.c Fri Mar 3 21:56:56 2000
+++ 16/nat_cmd.c Sat Mar 4 02:04:52 2000
@@ -380,6 +380,7 @@
/* Ensure there's a bit of extra buffer for the NAT code... */
bp = m_pullup(m_append(bp, NULL, NAT_EXTRABUF));
ret = PacketAliasIn(MBUF_CTOP(bp), bp->m_len);
+ pip = (struct ip *)MBUF_CTOP(bp);
bp->m_len = ntohs(pip->ip_len);
if (bp->m_len > MAX_MRU) {
> Hi,
>
> Because of a recent change in the way I connect to the net
> (PPPoUDPoPPPoISDN), I'm now seeing this problem !
>
> Can you try the attached patch ? I believe this fixes the problem !
>
> For those that have forgotten this thread, the issue is with
> fragmented packets going through ppps NAT implementation. Peter was
> the first to point out an occasional error message saying ``Problem
> with IP header length''. It turns out that the bug is a couple of
> lines above (see the patch), and was worsened (made consistent enough
> to make a given tcp/udp session freeze) by my recent mbuf memory
> allocation optimisations !!!
>
> Thanks for any confirmations.
>
> Jordan (cc'd) is in Holland at the moment, so I suspect nobody's
> going to approve this for 4.0 and it'll have to stay as
> queued-patch-#16 here on my laptop - unless I can collar him as
> he passes through the UK on Sunday !!!! Any news Joe (cc'd) ?
>
> > On Thu, 17 Feb 2000, Brian Somers wrote:
> >
> > > If it still happens with the latest verison, can you also try
> > > decreasing your network MTU to 1492 (or maybe even 1400 for kicks).
> > > This would stop IP fragmentation - it shouldn't make a difference,
> > > but, well....
> >
> > I've just realised that you're talking about my inside MTU - I haven't
> > even touched that yet. I'll try it.
> >
> > Cheers,
> > Dermot
--
Brian <brian@Awfulhak.org> <brian@[uk.]FreeBSD.org>
<http://www.Awfulhak.org>; <brian@[uk.]OpenBSD.org>
Don't _EVER_ lose your sense of humour !
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200003041105.LAA07495>