Date: Fri, 28 Dec 2012 04:14:25 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Oleksandr Tymoshenko <gonzo@freebsd.org> Cc: svn-src-head@freebsd.org, Jeff Roberson <jeff@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r244445 - in head/sys: kern sys tools Message-ID: <20121228021425.GO82219@kib.kiev.ua> In-Reply-To: <50DCFDEE.8080404@freebsd.org> References: <201212192010.qBJKA0lb075959@svn.freebsd.org> <50DCFDEE.8080404@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--TYjWXklH5JTzT8n9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 27, 2012 at 06:03:26PM -0800, Oleksandr Tymoshenko wrote: > On 12/19/2012 12:10 PM, Jeff Roberson wrote: > > Author: jeff > > Date: Wed Dec 19 20:10:00 2012 > > New Revision: 244445 > > URL: http://svnweb.freebsd.org/changeset/base/244445 > > > > Log: > > - Add new machine parsable KTR macros for timing events. > > - Use this new format to automatically handle syscalls and VOPs. T= his > > changes the earlier format but is still human readable. > > =20 > > Sponsored by: EMC / Isilon Storage Division >=20 > Jeff, >=20 > please fix tinderbox breakage caused by this commit >=20 > ARM kernel build with KTR option is still broken as of today: >=20 > http://tinderbox.freebsd.org/tinderbox-head-ss-build-HEAD-arm-arm.brief >=20 > In file included from /src/sys/arm/arm/trap.c:900: > /src/sys/arm/arm/../../kern/subr_syscall.c: In function 'syscallenter': > /src/sys/arm/arm/../../kern/subr_syscall.c:80: warning: cast from pointer= to integer of different size [-Wpointer-to-int-cast] > /src/sys/arm/arm/../../kern/subr_syscall.c:154: warning: cast from pointe= r to integer of different size [-Wpointer-to-int-cast] > *** [trap.o] Error code 1 >=20 >=20 > Thank you I am running a fix through the make universe right now. If you can compile just ARM and confirm that gcc is silenced by this, I will commit it before make universe finishes. diff --git a/sys/kern/subr_syscall.c b/sys/kern/subr_syscall.c index 3dcfcf5..349b410 100644 --- a/sys/kern/subr_syscall.c +++ b/sys/kern/subr_syscall.c @@ -77,7 +77,7 @@ syscallenter(struct thread *td, struct syscall_args *sa) if (KTRPOINT(td, KTR_SYSCALL)) ktrsyscall(sa->code, sa->narg, sa->args); #endif - KTR_START4(KTR_SYSC, "syscall", syscallname(p, sa->code), + KTR_START4(KTR_SYSC, "syscall", (uintptr_t)syscallname(p, sa->code), td, "pid:%d", td->td_proc->p_pid, "arg0:%p", sa->args[0], "arg1:%p", sa->args[1], "arg2:%p", sa->args[2]); =20 @@ -151,7 +151,7 @@ syscallenter(struct thread *td, struct syscall_args *sa) syscall_thread_exit(td, sa->callp); } retval: - KTR_STOP4(KTR_SYSC, "syscall", syscallname(p, sa->code), + KTR_STOP4(KTR_SYSC, "syscall", (uintptr_t)syscallname(p, sa->code), td, "pid:%d", td->td_proc->p_pid, "error:%d", error, "retval0:%#lx", td->td_retval[0], "retval1:%#lx", td->td_retval[1]); --TYjWXklH5JTzT8n9 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJQ3QCBAAoJEJDCuSvBvK1BwoYP/1vlrEZu1V4oKq79XOgLmGI3 Pl13nAdPe6HsQHDuW3WHzIQyG+WYDKHT/qy1+xwalxQ5N4RqQCQoHRwpb5UvgmyK i2E1jQk0GgUAAOIDr5fi+8eNlr1yyg2PsguXz6UiTKV76pmOhHjHBYVZZZO8uD3u Y++D8wDQn+SL/DIU7wTV571BYXYZt1C4AHt3CmVbvEtSYkTndgUPmgHkSwUjeueq Dio25f7Lajs9SEZUIvhTK1GoVdhfVBP0UjKdUH3USLb9NLF3l8YeLscglLzzE0hR 5pdLcI/1Lyk6ZJ6CvZ+Q51Tjk/rbsJjZpNeKkJkGgCPlMaXWBTs7yFYwqRUufVuy yALTFlvQzuTj2u2CbXYBRUXG1gvuF3CU1jryFBFcsNKu9p1dJRYV/7vgpxxClk9q AAOXqRCfEQ2RPMoBxQckOPTggJck488pDUD0eg2wwcvmSOaxnHcgmCmVxDMe+MsA WDl+sWJc26rkyVkL4hOYff9BLjYNZ14lsZFwr9JgJFe2QZZsLdq8Vc1RdggVs5MD a7q04x+NmGkSz4TRallIl+9SnLUDZ791qzdw8DRAY7+SOzV1qB4B1IADBtQ6iXa9 IfYd2GOffcabfndlVeagx+n1ZYyEJZF4bgzUAP0g/ZEGfxgiJr4qoyx1qv4qU16X DPvsvfanAydBB7cbHDgm =1fWz -----END PGP SIGNATURE----- --TYjWXklH5JTzT8n9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121228021425.GO82219>