Date: Sun, 15 Jan 2006 20:23:04 +0300 (MSK) From: Dmitry Marakasov <amdmi3@mail.ru> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/91834: [PATCH] Cleaner use of INSTALLS_OMF with no scrollkeeper installed Message-ID: <20060115172304.4449D5A@hades.panopticon> Resent-Message-ID: <200601151720.k0FHK37K010634@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 91834 >Category: ports >Synopsis: [PATCH] Cleaner use of INSTALLS_OMF with no scrollkeeper installed >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Jan 15 17:20:03 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Dmitry Marakasov >Release: FreeBSD 6.0-RELEASE i386 >Organization: >Environment: System: FreeBSD hades.panopticon 6.0-RELEASE FreeBSD 6.0-RELEASE #1: Sun Dec 18 08:07:07 MSK 2005 amdmi3@hades.panopticon:/usr/obj/usr/src/sys/HADES i386 >Description: Some ports install .omf (opensource metadata framework) files, which are intended for use with scrollkeeper (ports/textproc/scrollkeeper). As these files need to be registered with scrollkeper, there's knob INSTALLS_OMF, which, if set, makes bsd.gnome.mk automatically add @exec/@unexec directives to ports' plist. These do scrollkeeper-install/scrollkeeper-uninstall calls on package installation/deinstallation. But when scrollkeeper is not installed on a system, errors will appear: `scrollkeeper-install: not found' `scrollkeeper-uninstall: not found' on installation/deinstallation of a package because nonexisting binaries are being called. These errors are harmless, as scrollkeeper calls are done as `scrollkeeper-(un)install || true', but still annoying/confusing. That is, of course, bad idea to add dependency on scrollkeeper to ports that just INSTALLS_OMF, so I recommend to modify bsd.gnome.mk a little, so before calling scrollkeeper-(un)install it will be checked for existence with `which -s'. !!! Also, I've just found out that when installing software from port, scrollkeeper-install doesn't get called at all (as @exec is only called when installing prom package). I have no fix for that yet. >How-To-Repeat: >Fix: --- bsd.gnome.mk.patch begins here --- --- bsd.gnome.mk.orig Tue Jan 10 18:23:54 2006 +++ bsd.gnome.mk Sun Jan 15 19:34:37 2006 @@ -730,9 +730,9 @@ . if defined(INSTALLS_OMF) @for i in `${GREP} "\.omf$$" ${TMPPLIST}`; do \ - ${ECHO_CMD} "@exec scrollkeeper-install -q %D/$${i} 2>/dev/null || /usr/bin/true" \ + ${ECHO_CMD} "@exec which -s scrollkeeper-install && scrollkeeper-install -q %D/$${i} 2>/dev/null || /usr/bin/true" \ >> ${TMPPLIST}; \ - ${ECHO_CMD} "@unexec scrollkeeper-uninstall -q %D/$${i} 2>/dev/null || /usr/bin/true" \ + ${ECHO_CMD} "@unexec which -s scrollkeeper-uninstall && scrollkeeper-uninstall -q %D/$${i} 2>/dev/null || /usr/bin/true" \ >> ${TMPPLIST}; \ done . endif --- bsd.gnome.mk.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060115172304.4449D5A>