Date: Thu, 8 Aug 2013 13:41:56 -0400 From: Glen Barber <gjb@FreeBSD.org> To: Hiroki Sato <hrs@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r254094 - head/sys/conf Message-ID: <20130808174156.GC2162@glenbarber.us> In-Reply-To: <20130809.020153.1826008782812656990.hrs@allbsd.org> References: <201308081559.r78Fx1h6034578@svn.freebsd.org> <20130809.020153.1826008782812656990.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--CblX+4bnyfN0pR09 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 09, 2013 at 02:01:53AM +0900, Hiroki Sato wrote: > I think this logic is unnecessarily complex. svnversion does not > need to run twice, at least. >=20 svnversion is only invoked the first time on the newvers.sh file, so the impact is minimal. > How about the attached patch? >=20 I have no objection. Glen --CblX+4bnyfN0pR09 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iQEcBAEBCAAGBQJSA9hkAAoJEFJPDDeguUajrI4IAJCQD+sRebD2wWbP43iTX0r6 uzsZPIJW+JRIi5nI1CPe+7AtJb+BE9EiObaKlttEb5KpwvdrlDhDoT3Cm/Fug+SY rpbsdGaUarGSYEry4LJXADZP5EOMgmZclz2J901qnxU93tmtERTzjJcv4PG/xfBc o3z3C5aJ9p/8YD4tNVCUdYyaCqLMY8q6z0JU76LjhUO/XqEVZgIfJ2sBRcCeiIsl GDMd5msaTyzq2g+qFapZUPwfkWps/n/vx1pXiqwIrZQp2cceDG5jkmwCaSUpmg25 gwwzRLERo2o1KpLjYh3qeyQsUkFFvgOXVw0CgV8AKq32HqiRkLef7MBXocFHlkU= =B0Zz -----END PGP SIGNATURE----- --CblX+4bnyfN0pR09--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130808174156.GC2162>