Date: Fri, 02 Dec 2011 11:02:02 -0500 From: Greg Larkin <glarkin@FreeBSD.org> To: Wesley Shields <wxs@FreeBSD.org> Cc: Michael Scheidell <michael.scheidell@secnap.com>, "'cvs-ports@FreeBSD.org'" <cvs-ports@FreeBSD.org>, "'cvs-all@FreeBSD.org'" <cvs-all@FreeBSD.org>, "'ports-committers@FreeBSD.org'" <ports-committers@FreeBSD.org> Subject: Re: cvs commit: ports/security/fprint_demo Makefile distinfo pkg-plist Message-ID: <4ED8F67A.1040702@FreeBSD.org> In-Reply-To: <20111202154352.GH56180@atarininja.org> References: <201111292239.pATMdtGq022326@repoman.freebsd.org> <20111202140059.GG56180@atarininja.org> <20B7E8C1930569419B93027F125DAB1506D1E214@USBCTDC001> <20111202154352.GH56180@atarininja.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 12/2/11 10:43 AM, Wesley Shields wrote: > On Fri, Dec 02, 2011 at 02:16:32PM +0000, Michael Scheidell wrote: [...] > >>> | --- ports/security/fprint_demo/distinfo 2011/11/29 12:59:55 1.3 >>> | +++ ports/security/fprint_demo/distinfo 2011/11/29 22:39:55 1.4 >>> | @@ -1,2 +1,4 @@ >>> | -SHA256 (fprint-demo_20080303+git.orig.tar.gz) = >>> | fcff7f6e8d61b253b88dd87ecf5cdb5418ecf11178ce7cb6ae0e350485045232 >>> | -SIZE (fprint-demo_20080303+git.orig.tar.gz) = 77714 >>> | +SHA256 (fprint-demo_20080303git.orig.tar.gz) = >>> | +fcff7f6e8d61b253b88dd87ecf5cdb5418ecf11178ce7cb6ae0e350485045232 >>> | +SIZE (fprint-demo_20080303git.orig.tar.gz) = 77714 >>> | +#http://mirrors.arsc.edu/ubuntu/packages/pool/ >>> | +#universe/f/fprint-demo/fprint-demo_20080303git.orig.tar.gz >> >> Are these last two lines really meant to be there? >> >> Mostly to document that its in a STRANGE place (pam_fprint is in >> _20080203+git) > > Not where I would put it. I'd put this information in the Makefile along > with a comment explaining it. Again, no major harm and this is your port > but the norm is to keep this information in Makefile and leave distinfo > for recording size and checksums only. > > -- WXS Plus, the entire distinfo file will be rewritten from scratch the next time "make makesum" is run, and any comments will be lost. Regards, Greg - -- Greg Larkin http://www.FreeBSD.org/ - The Power To Serve http://www.sourcehosting.net/ - Ready. Set. Code. http://twitter.com/cpucycle/ - Follow you, follow me -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7Y9noACgkQ0sRouByUApC8xACfUiIBa3Cg3og4cNVukE6vILWH Md8AoLDRJCa//hxk0LgypBTWgZku4BXd =qTGn -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4ED8F67A.1040702>