Date: Thu, 9 Feb 2012 19:41:03 -0500 From: Eitan Adler <eadler@freebsd.org> To: Andrey Chernov <ache@freebsd.org>, Eitan Adler <eadler@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r231300 - head/usr.sbin/pkg_install/create Message-ID: <CAF6rxg=L%2BUGj6BFP2NDsEcWBQBhVcN_Zuntk=%2BvcEPuLsR5t0w@mail.gmail.com> In-Reply-To: <20120210002623.GA79894@vniz.net> References: <201202092051.q19Kp3pj028436@svn.freebsd.org> <20120210002623.GA79894@vniz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 9, 2012 at 7:26 PM, Andrey Chernov <ache@freebsd.org> wrote:
> On Thu, Feb 09, 2012 at 08:51:03PM +0000, Eitan Adler wrote:
>> /* Prefix should add an @cwd to the packing list */
>> - if (Prefix)
>> - add_plist_top(&plist, PLIST_CWD, Prefix);
>> + if (Prefix) {
>> + char resolved_prefix[PATH_MAX];
>> + if (realpath(Prefix, resolved_prefix) != 0)
>> + err(EXIT_FAILURE, "couldn't resolve path for prefix: %s", Prefix);
>> + add_plist_top(&plist, PLIST_CWD, resolved_prefix);
>> + }
>
> This change cause
> "pkg_create: couldn't resolve path for prefix: /usr/local: No such file or
> directory"
> because test condition should really be:
Patch sent - awaiting approval. Sorry for the breakage :(
--
Eitan Adler
Source & Ports committer
X11, Bugbusting teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxg=L%2BUGj6BFP2NDsEcWBQBhVcN_Zuntk=%2BvcEPuLsR5t0w>